From: jschopp <jschopp@austin.ibm.com>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: Andy Whitcroft <apw@shadowen.org>, Andrew Morton <akpm@osdl.org>,
Randy Dunlap <rdunlap@xenotime.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] update checkpatch.pl to version 0.08
Date: Tue, 24 Jul 2007 08:58:25 -0500 [thread overview]
Message-ID: <46A60581.90800@austin.ibm.com> (raw)
In-Reply-To: <46A53F3A.7060509@intel.com>
> within the last 3 weeks, this script went from *really usable* to *a big
> noise maker*.
As we (mostly Andy of late) add more checks (good) there is bound to be some code we just
didn't forsee that generates false positives (bad). You can see a consistent history of
cleaning these up as quickly as people send them in. Hopefully in the interim there
aren't too many false positives and the script is still useful. We do try to put the new
tests through their paces before adding them in, but our imaginations are limited.
The goal has always been to err on the side of missing badness in code to avoid false
positives. This way, when there is output it has a very high chance of not wasting your
time. Wait a couple weeks and it'll be there again.
> Bottom line: I really wish that I could have the script run in the old
> behaviour before. While this level of verbosity is great for single-line
> patches, it really completely wastes my time when I'm trying to get a
> grasp for a 200k hunk piece of code.
I think it would be a great idea to have the script default to very conservative behavior
and have a flag say --verbose to turn on checks that have a higher false positive rate
(such as the multiple variable declarations per line). This might also be a staging area
for newer checks to get a chance to work out some kinks before being added to the default.
next prev parent reply other threads:[~2007-07-24 13:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-15 8:25 [PATCH] update checkpatch.pl to version 0.08 Andy Whitcroft
2007-07-23 23:08 ` Kok, Auke
2007-07-24 0:11 ` Randy Dunlap
2007-07-24 9:06 ` Andy Whitcroft
2007-07-24 9:15 ` Andrew Morton
2007-07-24 11:19 ` Andy Whitcroft
2007-07-24 13:08 ` Dmitry Torokhov
2007-07-24 16:51 ` Jan Engelhardt
2007-07-24 17:20 ` Randy Dunlap
2007-07-24 17:46 ` Jan Engelhardt
2007-07-24 18:03 ` Randy Dunlap
2007-07-24 18:30 ` Andy Whitcroft
2007-07-24 17:22 ` Paul Mundt
2007-07-24 18:00 ` Jan Engelhardt
2007-07-24 18:31 ` Andy Whitcroft
2007-07-24 19:49 ` Adrian Bunk
2007-07-24 20:32 ` jschopp
2007-07-25 1:13 ` Adrian Bunk
2007-07-25 15:39 ` SL Baur
2007-07-25 16:54 ` Adrian Bunk
2007-07-24 18:45 ` jschopp
2007-07-24 19:59 ` Adrian Bunk
2007-07-24 20:53 ` jschopp
2007-07-23 23:13 ` Jesper Juhl
2007-07-23 23:36 ` Kok, Auke
2007-07-24 16:53 ` Jan Engelhardt
2007-07-24 17:06 ` Andy Whitcroft
2007-08-03 12:37 ` Andy Whitcroft
2007-07-23 23:52 ` Kok, Auke
2007-07-24 11:33 ` Andy Whitcroft
2007-07-24 11:47 ` Ingo Molnar
2007-07-24 11:51 ` Ingo Molnar
2007-07-24 16:56 ` Jan Engelhardt
2007-07-24 18:38 ` Andy Whitcroft
2007-07-24 13:58 ` jschopp [this message]
2007-07-24 14:33 ` Adrian Bunk
2007-07-24 14:50 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A60581.90800@austin.ibm.com \
--to=jschopp@austin.ibm.com \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=auke-jan.h.kok@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox