From: Andy Whitcroft <apw@shadowen.org>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: "Kok, Auke" <auke-jan.h.kok@intel.com>,
Andrew Morton <akpm@osdl.org>,
Randy Dunlap <rdunlap@xenotime.net>,
Joel Schopp <jschopp@austin.ibm.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] update checkpatch.pl to version 0.08
Date: Tue, 24 Jul 2007 19:38:23 +0100 [thread overview]
Message-ID: <46A6471F.1090003@shadowen.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0707241854140.18990@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Jul 24 2007 12:33, Andy Whitcroft wrote:
>>> Warning on multiple declarations on a line is nice, but IMO really too
>>> verbose (why is "int i, j;" bad? Did C somehow change syntax today?).
>> No the normal response is two fold:
>>
>> 1) "what the heck are i and j those are meaningless names"
>
> Can we at least assume the submitter is sane in some ways?
> i and j are picked for obvious iterater values - you would not want
> verbosify that to fruit_iterator and process_iterator or whatever
> because it's a hell lot more typing.
> It takes more than a few Perl regexes to actually grasp the semantics
> of whether "i" is useful or not.
I was mearly quoting the what I'd seen. I am completely ambivalent on
the whole process. I had assumed when we updated the documentation to
strongly indicate that this was a style guide not a robot with patch
veto power that people would realise they could ignore those things they
disagreed with and things would be good.
checkpatch is only intended to tell you what a Reviewer is likely to
pick up and winge about and is intended to save _them_ time, their time
generally being more limited that yours if for no other reason than you
want your patch in, and they may have no vested interest.
That said I want it to be as unannoying as we can and we will have
loosened most of the checks you do not like in the next release.
-apw
next prev parent reply other threads:[~2007-07-24 18:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-15 8:25 [PATCH] update checkpatch.pl to version 0.08 Andy Whitcroft
2007-07-23 23:08 ` Kok, Auke
2007-07-24 0:11 ` Randy Dunlap
2007-07-24 9:06 ` Andy Whitcroft
2007-07-24 9:15 ` Andrew Morton
2007-07-24 11:19 ` Andy Whitcroft
2007-07-24 13:08 ` Dmitry Torokhov
2007-07-24 16:51 ` Jan Engelhardt
2007-07-24 17:20 ` Randy Dunlap
2007-07-24 17:46 ` Jan Engelhardt
2007-07-24 18:03 ` Randy Dunlap
2007-07-24 18:30 ` Andy Whitcroft
2007-07-24 17:22 ` Paul Mundt
2007-07-24 18:00 ` Jan Engelhardt
2007-07-24 18:31 ` Andy Whitcroft
2007-07-24 19:49 ` Adrian Bunk
2007-07-24 20:32 ` jschopp
2007-07-25 1:13 ` Adrian Bunk
2007-07-25 15:39 ` SL Baur
2007-07-25 16:54 ` Adrian Bunk
2007-07-24 18:45 ` jschopp
2007-07-24 19:59 ` Adrian Bunk
2007-07-24 20:53 ` jschopp
2007-07-23 23:13 ` Jesper Juhl
2007-07-23 23:36 ` Kok, Auke
2007-07-24 16:53 ` Jan Engelhardt
2007-07-24 17:06 ` Andy Whitcroft
2007-08-03 12:37 ` Andy Whitcroft
2007-07-23 23:52 ` Kok, Auke
2007-07-24 11:33 ` Andy Whitcroft
2007-07-24 11:47 ` Ingo Molnar
2007-07-24 11:51 ` Ingo Molnar
2007-07-24 16:56 ` Jan Engelhardt
2007-07-24 18:38 ` Andy Whitcroft [this message]
2007-07-24 13:58 ` jschopp
2007-07-24 14:33 ` Adrian Bunk
2007-07-24 14:50 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A6471F.1090003@shadowen.org \
--to=apw@shadowen.org \
--cc=akpm@osdl.org \
--cc=auke-jan.h.kok@intel.com \
--cc=jengelh@computergmbh.de \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox