From: Jeff Garzik <jeff@garzik.org>
To: Micah Gruber <micah.gruber@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] [2.6.22] Fix a potential NULL pointer dereference in mace_interrupt() in drivers/net/pcmcia/nmclan_cs.c
Date: Tue, 24 Jul 2007 16:24:15 -0400 [thread overview]
Message-ID: <46A65FEF.2030303@garzik.org> (raw)
In-Reply-To: <46A567A8.6050409@gmail.com>
Micah Gruber wrote:
> This patch fixes a potential null dereference bug where we dereference
> DEV before a null check. This patch simply moves the dereferencing after
> the null check.
>
> Signed-off-by: Micah Gruber <micah.gruber@gmail.com>
>
> ---
>
> --- a/drivers/net/pcmcia/nmclan_cs.c +++
> b/drivers/net/pcmcia/nmclan_cs.c @@ -996,7 +996,7 @@
PLEASE PLEASE PLEASE fix your mailer.
None of your patches are apply-able via script or patch(1), which is how
all Linux maintainers apply patches.
If you want to contribute to the kernel, you -must- figure out how to
send patches via email.
Linux kernel development is done almost exclusively through email, so it
is very important to get the details right.
Jeff
next prev parent reply other threads:[~2007-07-24 20:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 2:44 [PATCH] [2.6.22] Fix a potential NULL pointer dereference in mace_interrupt() in drivers/net/pcmcia/nmclan_cs.c Micah Gruber
2007-07-24 20:24 ` Jeff Garzik [this message]
2007-07-30 19:59 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A65FEF.2030303@garzik.org \
--to=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micah.gruber@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox