Re: [PATCH] update checkpatch.pl to version 0.08

Kok, Auke
2007-07-23T23:36:28Z

Andy Whitcroft wrote:
> This version brings a number of new checks, and a number of bug
> fixes. Of note:
>
> - warnings for multiple assignments per line
> - warnings for multiple declarations per line
> - checks for single statement blocks with braces
>
> This patch includes an update for feature-removal-schedule.txt to
> better target checks.
>
> Andy Whitcroft (12):
> Version: 0.08
> check for spaces between function name and open parenthesis
>

> +# check for spaces between functions and their parentheses.
> + if ($line =~ /($Ident)\s+\(/ &&
> + $1 !~ /^(?:if|for|while|switch|return|volatile)$/ &&
> + $line !~ /$Type\s+\(/ && $line !~ /^.\#\s*define\b/) {
> + ERROR("no space between function name and open parenthesis '('\n" . $herecurr);
> + }

this somehow seems to match something completely non-related (a function pointer
declaration case):

ERROR: no space between function name and open parenthesis '('
#7278: FILE: drivers/net/e1000e/hw.h:434:
+ bool (*check_mng_mode)(struct e1000_hw *);

even if I put a space between ")(", it still complains.

Auke