Re: [PATCH] update checkpatch.pl to version 0.08

Jesper Juhl
2007-07-23T23:13:21Z

On 15/07/07, Andy Whitcroft <apw@shadowen.org> wrote:
>
> This version brings a number of new checks, and a number of bug
> fixes. Of note:
>
> - warnings for multiple assignments per line
> - warnings for multiple declarations per line
> - checks for single statement blocks with braces
>
> This patch includes an update for feature-removal-schedule.txt to
> better target checks.
>
> Andy Whitcroft (12):
> Version: 0.08
> only apply printk checks where there is a string literal
> allow suppression of errors for when no patch is found
> warn about multiple assignments
> warn on declaration of multiple variables
> check for kfree() with needless null check

It's not just kfree(), it's a whole list of functions, like kfree(),
vfree(), crypto_free_tfm() and a bunch of other freeing functions...

> check for single statement braced blocks

Hmmm, if the single statement is a macro, braces sometimes make a lot
of sense...

Suggested further improvement; check that patches don't modify files
listed in Documentation/dontdiff

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html