Re: [PATCH] update checkpatch.pl to version 0.08

Adrian Bunk
2007-07-25T16:54:58Z

On Wed, Jul 25, 2007 at 08:39:36AM -0700, SL Baur wrote:
> On 7/24/07, Adrian Bunk <bunk@stusta.de> wrote:
>
>> There are more important things than exploiting the corner cases of
>> codingstyle, e.g. could you teach checkpatch.pl to give exactly two
>> errors for the following code?
>>
>>
>> while (a);
>> for (b = 0; b < 50; b++);
>> for (c = 0; c < sizeof(struct module); c++)
>> d = e;
>
> There are three errors there. The while (a) busy wait needs a cpu_relax()

OK, granted. But this is dummy code, and this is not what I'd expect
checkpatch.pl to check for.

> or something, the first for is at the wrong level of indentation and the
> second for is at the wrong level of indentation relative to the first one.

If someone writes the code this way, the problem is usually not the
indentation that is most likely correct, but the fact that the code does
something completely different from what the author thought it would do.

We already had such bugs in the kernel, they are unlikely to be spotted
at code review, but for a script that looks at the source code they
should be easy to spot.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed