From: jschopp <jschopp@austin.ibm.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Paul Mundt <lethal@linux-sh.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@shadowen.org>,
"Kok, Auke" <auke-jan.h.kok@intel.com>,
Randy Dunlap <rdunlap@xenotime.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] update checkpatch.pl to version 0.08
Date: Tue, 24 Jul 2007 15:53:34 -0500 [thread overview]
Message-ID: <46A666CE.4010905@austin.ibm.com> (raw)
In-Reply-To: <20070724195908.GF6019@stusta.de>
>> So, no we shouldn't separate out CodingStyle because
>>
>> Better CodingStyle == less bugs
>>
>> and
>>
>> Better CodingStyle == more throughput for maintainers
>
> To some extent yes.
>
> But extreme codingstyling won't gain you anything.
>
> Except for long and fruitless discussions.
>
> If a tool says anything would be wrong with the line of C code
> int i, j;
> for two loop variables, then the tool is wrong because that's an idiom
> every C programmer knows and understands.
I'm fine with whatever we decide is acceptable coding style, and changing the tool to
match is work I'm willing to do. If we decide declaring multiple variables on one line is
bad, except if they are named i,j, or k then that's fine. If we decide declaring 22
variables per line is OK but 23 per line is bad then I'm fine with that.
If a check doesn't complain about bad code hundreds of times for every 1 time it complains
about good code we will fix the check or remove the check entirely.
Andy already removed the multiple variable declaration per line check for the next version
for that reason, it complained about arguably good code too often (to be fair many would
say int i, j; is bad code). Someday when we get the check fixed to handle sane multiple
variable declarations better I'd like to add the check back in so the insane multiple
variable declarations gets warned.
next prev parent reply other threads:[~2007-07-24 20:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-15 8:25 [PATCH] update checkpatch.pl to version 0.08 Andy Whitcroft
2007-07-23 23:08 ` Kok, Auke
2007-07-24 0:11 ` Randy Dunlap
2007-07-24 9:06 ` Andy Whitcroft
2007-07-24 9:15 ` Andrew Morton
2007-07-24 11:19 ` Andy Whitcroft
2007-07-24 13:08 ` Dmitry Torokhov
2007-07-24 16:51 ` Jan Engelhardt
2007-07-24 17:20 ` Randy Dunlap
2007-07-24 17:46 ` Jan Engelhardt
2007-07-24 18:03 ` Randy Dunlap
2007-07-24 18:30 ` Andy Whitcroft
2007-07-24 17:22 ` Paul Mundt
2007-07-24 18:00 ` Jan Engelhardt
2007-07-24 18:31 ` Andy Whitcroft
2007-07-24 19:49 ` Adrian Bunk
2007-07-24 20:32 ` jschopp
2007-07-25 1:13 ` Adrian Bunk
2007-07-25 15:39 ` SL Baur
2007-07-25 16:54 ` Adrian Bunk
2007-07-24 18:45 ` jschopp
2007-07-24 19:59 ` Adrian Bunk
2007-07-24 20:53 ` jschopp [this message]
2007-07-23 23:13 ` Jesper Juhl
2007-07-23 23:36 ` Kok, Auke
2007-07-24 16:53 ` Jan Engelhardt
2007-07-24 17:06 ` Andy Whitcroft
2007-08-03 12:37 ` Andy Whitcroft
2007-07-23 23:52 ` Kok, Auke
2007-07-24 11:33 ` Andy Whitcroft
2007-07-24 11:47 ` Ingo Molnar
2007-07-24 11:51 ` Ingo Molnar
2007-07-24 16:56 ` Jan Engelhardt
2007-07-24 18:38 ` Andy Whitcroft
2007-07-24 13:58 ` jschopp
2007-07-24 14:33 ` Adrian Bunk
2007-07-24 14:50 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A666CE.4010905@austin.ibm.com \
--to=jschopp@austin.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=auke-jan.h.kok@intel.com \
--cc=bunk@stusta.de \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox