From: Greg Ungerer <gerg@snapgear.com>
To: Christoph Hellwig <hch@infradead.org>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [M68KNOMMU]: create hw_irq.h
Date: Wed, 25 Jul 2007 22:37:41 +1000 [thread overview]
Message-ID: <46A74415.7000408@snapgear.com> (raw)
In-Reply-To: <20070725121724.GA4923@infradead.org>
Christoph Hellwig wrote:
> On Wed, Jul 25, 2007 at 10:07:20PM +1000, Greg Ungerer wrote:
>> Need an include/asm-m68knommu/hw_irq.h for kernel/hrtimer.c
>
> hrtimer.c should be fixed not to include it instead.
Indirectly it is coming from include/linux/irq.h
(which means that compilation of a few kernel/irq/*.c files
fail on m68knommu without hw_irq.h existing too)
Can we just take out that include from there?
--- linux-2.6.23-rc1/include/linux/irq.h 2007-07-25
16:39:30.000000000 +1000
+++ linux/include/linux/irq.h 2007-07-25 22:36:28.000000000 +1000
@@ -186,11 +186,6 @@
#define no_irq_type no_irq_chip
typedef struct irq_desc irq_desc_t;
-/*
- * Pick up the arch-dependent methods:
- */
-#include <asm/hw_irq.h>
-
extern int setup_irq(unsigned int irq, struct irqaction *new);
#ifdef CONFIG_GENERIC_HARDIRQS
--
------------------------------------------------------------------------
Greg Ungerer -- Chief Software Dude EMAIL: gerg@snapgear.com
SnapGear -- a Secure Computing Company PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2007-07-25 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 12:07 [M68KNOMMU]: create hw_irq.h Greg Ungerer
2007-07-25 12:17 ` Christoph Hellwig
2007-07-25 12:37 ` Greg Ungerer [this message]
2007-07-25 13:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A74415.7000408@snapgear.com \
--to=gerg@snapgear.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox