From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763632AbXGYNOI (ORCPT ); Wed, 25 Jul 2007 09:14:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753815AbXGYNN5 (ORCPT ); Wed, 25 Jul 2007 09:13:57 -0400 Received: from il.qumranet.com ([82.166.9.18]:58969 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753871AbXGYNN4 (ORCPT ); Wed, 25 Jul 2007 09:13:56 -0400 Message-ID: <46A74C93.7080705@qumranet.com> Date: Wed, 25 Jul 2007 16:13:55 +0300 From: Avi Kivity User-Agent: Thunderbird 2.0.0.4 (X11/20070615) MIME-Version: 1.0 To: Ingo Molnar CC: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, shaohua.li@intel.com, rusty@rustcorp.com.au, Andi Kleen Subject: Re: [PATCH 1/3] SCHED: Generic hooks for trapping task preemption References: <11853673872732-git-send-email-avi@qumranet.com> <11853673871109-git-send-email-avi@qumranet.com> <20070725124911.GC6841@elte.hu> <20070725125220.GA8914@elte.hu> In-Reply-To: <20070725125220.GA8914@elte.hu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (firebolt.argo.co.il [0.0.0.0]); Wed, 25 Jul 2007 16:13:55 +0300 (IDT) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar wrote: > * Ingo Molnar wrote: > > >>> This adds a general mechanism whereby a task can request the >>> scheduler to notify it whenever it is preempted or scheduled back >>> in. This allows the task to swap any special-purpose registers like >>> the fpu or Intel's VT registers. >>> >> ok, this looks very clean, i've added it to my scheduler tree. You've >> tested this with KVM, on both 32-bit and 64-bit, correct? >> > > note: i've done a hook -> notifier rename - 'hook' is way too generic > sounding and also slightly loaded. (updated patch below) > > Okay, both i386 and x86_64 are happy (with the missing 'next' argument added, but with the old hook name). -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.