From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933461AbXGYRHg (ORCPT ); Wed, 25 Jul 2007 13:07:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758625AbXGYRH2 (ORCPT ); Wed, 25 Jul 2007 13:07:28 -0400 Received: from terminus.zytor.com ([198.137.202.10]:40027 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756376AbXGYRH1 (ORCPT ); Wed, 25 Jul 2007 13:07:27 -0400 Message-ID: <46A78253.3070709@zytor.com> Date: Wed, 25 Jul 2007 10:03:15 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.0 (X11/20070419) MIME-Version: 1.0 To: Jeremy Fitzhardinge CC: Linus Torvalds , David Miller , kaos@ocs.com.au, xyzzy@speakeasy.org, viro@ftp.linux.org.uk, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH][RFC] getting rid of stupid loop in BUG() References: <21803.1185331847@ocs10w.ocs.com.au> <46A6DB04.3000003@zytor.com> <46A6ECB7.7090208@goop.org> <20070724.232914.56812376.davem@davemloft.net> <46A781A4.40103@goop.org> In-Reply-To: <46A781A4.40103@goop.org> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jeremy Fitzhardinge wrote: > Linus Torvalds wrote: >> .. and I'm pretty sure it's immaterial. >> >> We don't just do the "ud2" instruction - we also do the file and line >> number information after it. Which means that __builtin_trap() is useless. >> > > No, not any more. The file and line info is out of line, in a separate > section, indexed by the ud2a's eip. The main problem with > __builtin_trap is that there's no certain way to get the actual ud2a eip > (ie, paste an asm label onto it). > Same difference, then... -hpa