From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934408AbXGYSjn (ORCPT ); Wed, 25 Jul 2007 14:39:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758929AbXGYSje (ORCPT ); Wed, 25 Jul 2007 14:39:34 -0400 Received: from az33egw01.freescale.net ([192.88.158.102]:43412 "EHLO az33egw01.freescale.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755529AbXGYSjd (ORCPT ); Wed, 25 Jul 2007 14:39:33 -0400 Message-ID: <46A798D8.7020906@freescale.com> Date: Wed, 25 Jul 2007 13:39:20 -0500 From: Scott Wood User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.10) Gecko/20050909 Red Hat/1.7.10-1.1.3.2 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Sergei Shtylyov CC: Vitaly Bordug , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface References: <20070725165318.5331.23795.stgit@localhost.localdomain> <20070725165326.5331.19920.stgit@localhost.localdomain> <46A78322.3080607@ru.mvista.com> <46A78E3F.1030904@ru.mvista.com> <20070725180145.GA29689@ld0162-tx32.am.freescale.net> <46A7941F.2050300@ru.mvista.com> In-Reply-To: <46A7941F.2050300@ru.mvista.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Sergei Shtylyov wrote: > Hello. > > Scott Wood wrote: > >>> Also, what mmio-ide in the compat properly means in the context of >>> ide_platform which is able to handle both port and memory mapped IDE. > > >> I/O-space is only valid in the context of PCI, ISA, or similar buses, and >> the bus-specific reg format indicates whether it's mmio-space or >> io-space. > > You could save time on lecturing me (and use it to look on the driver > ;-). Sorry, I misread the question as being a mismatch between the capabilities of the device binding and the driver, not about the specific compatible name. Something like "generic-ide" would probably be better. >> What is board specific about a set of standard IDE registers at a given > > The regisrer mapping used is highly non-standard. The gap between registers is nonstandard, but that's a fairly common type of noncompliance in embedded-land, and probably merits being supported in a generic way. I wouldn't call it "highly" nonstandard. Is there some other non-standardness that I'm missing? > We're already in board specific code, so why the heck not? :-) > >> various ns16550-compatibles out there as well? > > I never suggested that -- what I did suggest was make of_serial.c > recognize certain chip types and register them with 8250 driver. What would be the advantage of maintaining a list of chips whose only difference is register spacing, rather than just using reg-shift and being done with it? -Scott