Re: [-mm patch] DMA engine kconfig improvements

Dan Williams
2007-08-04T02:15:42Z

On 7/25/07, Adrian Bunk <bunk@stusta.de> wrote:
> On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.22-rc6-mm1:
> >...
> > +dma-arch-fix.patch
> >
> > Fix git-dma.patch
> >...
>
> This results in an ARM-only driver in an X86-only menu...
>
> What about the patch below instead that also improves a few other things?
I like it, just a few nits:

> -menu "DMA Engine support"
> - depends on HAS_DMA
> +menuconfig DMADEVICES
> + bool "DMA Engine support"
> + depends on (PCI && X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX
> + help
> + Intel(R) DMA engines
> +
Perhaps we should go ahead and define ARCH_HAS_DMA_OFFLOAD and have
DMADEVICES depend on that option. A ppc32 driver is in the works:
http://marc.info/?l=linux-raid&m=117400143317440&w=2

> +if DMADEVICES
> +
> +comment "DMA Devices"
> +
> +config INTEL_IOATDMA
> + tristate "Intel I/OAT DMA support"
> + depends on PCI && X86
> + select DMA_ENGINE
> + select DCA
> + help
> + Enable support for the Intel(R) I/OAT DMA engine present
> + in recent Intel Xeon CPUs.
> +
> + Say yes if you have such a CPU.
It is actually in recent chipsets, not the CPU, but yes the user
should have more help making this decision.

Regards,
Dan (for Shannon while he is on vacation)