Re: 2.6.23-rc1-mm1: SCSI_SRP_ATTRS compile error

FUJITA Tomonori
2007-07-26T10:58:21Z

From: Adrian Bunk <bunk@stusta.de>
Subject: 2.6.23-rc1-mm1: SCSI_SRP_ATTRS compile error
Date: Wed, 25 Jul 2007 20:06:18 +0200

> On Wed, Jul 25, 2007 at 05:36:56PM +0100, Andy Whitcroft wrote:
> > Of the machines we test releases on automatically this only compiles on
> > NUMA-Q and does not boot there (some PCI issue).
> >
> >
> > ppc64 (beavis):
> >
> > drivers/built-in.o(.text+0xd2784): In function `.srp_rport_add':
> > : undefined reference to `.scsi_tgt_it_nexus_create'
> > drivers/built-in.o(.text+0xd2884): In function `.srp_rport_del':
> > : undefined reference to `.scsi_tgt_it_nexus_destroy'
> > make: *** [.tmp_vmlinux1] Error 1
> >
> >
> > x86_64 (bl6-13):
> >
> > ERROR: "scsi_tgt_it_nexus_destroy" [drivers/scsi/scsi_transport_srp.ko]
> > undefined!
> > ERROR: "scsi_tgt_it_nexus_create" [drivers/scsi/scsi_transport_srp.ko]
> > undefined!
> > make[1]: *** [__modpost] Error 1
> >...
>
> Caused-By : git-scsi-target.patch
> Workaround : enable CONFIG_SCSI_TGT

Sorry about this.

Andrew, could you drop the scsi-target tree from -mm?

I was surprised that the scsi-target tree is still in -mm (it had been
tested in -mm before the mainline inclusion). I guess that it's the
right way to push scsi-target stuff into -mm via James' scsi-misc.

> Is there any good reason why all the SCSI transport attributes options
> are user visible?

No, I messed up the dependency somewhere. I'll fix it before it is
merged into scsi-misc.

Thanks,