From: Chris Snook <csnook@redhat.com>
To: "Li, Tong N" <tong.n.li@intel.com>
Cc: Chris Friesen <cfriesen@nortel.com>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] scheduler: improve SMP fairness in CFS
Date: Wed, 25 Jul 2007 18:24:23 -0400 [thread overview]
Message-ID: <46A7CD97.4020903@redhat.com> (raw)
In-Reply-To: <1185398148.3162.5.camel@tongli.jf.intel.com>
Li, Tong N wrote:
> On Wed, 2007-07-25 at 16:55 -0400, Chris Snook wrote:
>> Chris Friesen wrote:
>>> Ingo Molnar wrote:
>>>
>>>> the 3s is the problem: change that to 60s! We no way want to
>>>> over-migrate for SMP fairness, the change i did gives us reasonable
>>>> long-term SMP fairness without the need for high-rate rebalancing.
>>> Actually, I do have requirements from our engineering guys for
>>> short-term fairness. They'd actually like decent fairness over even
>>> shorter intervals...1 second would be nice, 2 is acceptable.
>>>
>>> They are willing to trade off random peak performance for predictability.
>>>
>>> Chris
>>>
>> The sysctls for CFS have nanosecond resolution. They default to
>> millisecond-order values, but you can set them much lower. See sched_fair.c for
>> the knobs and their explanations.
>>
>> -- Chris
>
> This is incorrect. Those knobs control local-CPU fairness granularity
> but have no control over fairness across CPUs.
>
> I'll do some benchmarking as Ingo suggested.
>
> tong
CFS naturally enforces cross-CPU fairness anyway, as Ingo demonstrated.
Lowering the local CPU parameters should cause system-wide fairness to converge
faster. It might be worthwhile to create a more explicit knob for this, but I'm
inclined to believe we could do it in much less than 700 lines. Ingo's
one-liner to improve the 10/8 balancing case, and the resulting improvement,
were exactly what I was saying should be possible and desirable. TCP Nagle
aside, it generally shouldn't take 700 lines of code to speed up the rate of
convergence of something that already converges.
Until now I've been watching the scheduler rewrite from the sidelines, but I'm
digging into it now. I'll try to give some more constructive criticism soon.
-- Chris
next prev parent reply other threads:[~2007-07-25 22:24 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 18:38 [RFC] scheduler: improve SMP fairness in CFS Tong Li
2007-07-23 20:00 ` Andi Kleen
2007-07-23 21:10 ` Li, Tong N
2007-07-23 21:25 ` Chris Friesen
2007-07-24 9:43 ` Andi Kleen
2007-07-23 23:40 ` Chris Snook
2007-07-24 8:07 ` Chris Snook
2007-07-24 17:11 ` Li, Tong N
2007-07-24 17:07 ` Tong Li
2007-07-24 18:08 ` Chris Snook
2007-07-24 19:47 ` Chris Friesen
2007-07-24 20:39 ` Chris Snook
2007-07-24 20:58 ` Li, Tong N
2007-07-24 21:09 ` Chris Snook
2007-07-24 21:23 ` Chris Friesen
2007-07-24 21:45 ` Chris Snook
2007-07-24 23:33 ` Chris Friesen
2007-07-24 21:06 ` Bill Huey
2007-07-24 21:22 ` Chris Snook
2007-07-24 23:14 ` Bill Huey
2007-07-24 21:12 ` Chris Friesen
2007-07-25 11:01 ` Ingo Molnar
2007-07-25 12:03 ` Ingo Molnar
2007-07-25 17:23 ` Tong Li
2007-07-25 19:24 ` Ingo Molnar
2007-07-25 20:38 ` Chris Friesen
2007-07-25 20:55 ` Chris Snook
2007-07-25 21:15 ` Li, Tong N
2007-07-25 22:24 ` Chris Snook [this message]
2007-07-26 19:00 ` Tong Li
2007-07-26 21:31 ` Ingo Molnar
2007-07-26 22:00 ` Li, Tong N
2007-07-27 1:34 ` Tong Li
2007-07-27 17:16 ` Chris Snook
2007-07-27 19:03 ` Tong Li
2007-07-27 22:20 ` Bill Huey
2007-07-27 23:36 ` Chris Snook
2007-07-28 0:54 ` Bill Huey
2007-07-28 2:59 ` Chris Snook
2007-07-28 19:38 ` Tong Li
2007-07-29 2:40 ` Chris Snook
2007-07-28 19:23 ` Tong Li
2007-07-29 3:01 ` Chris Snook
2007-07-25 18:20 ` Li, Tong N
2007-07-25 19:18 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A7CD97.4020903@redhat.com \
--to=csnook@redhat.com \
--cc=cfriesen@nortel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tong.n.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox