From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH] MAINTAINERS: use relevant mailing lists
Date: Thu, 26 Jul 2007 17:31:41 -0700 [thread overview]
Message-ID: <46A93CED.9090002@oracle.com> (raw)
In-Reply-To: <9a8748490707261717i247e7cbcgbf01ee9c69d21e3@mail.gmail.com>
Jesper Juhl wrote:
> On 27/07/07, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Add text on using relevant mailing lists.
>>
>
> I'd add a little bit to that - see below
>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> ---
>> MAINTAINERS | 13 ++++++++-----
>> 1 file changed, 8 insertions(+), 5 deletions(-)
>>
>> --- linux-2623-rc1g2.orig/MAINTAINERS
>> +++ linux-2623-rc1g2/MAINTAINERS
>> @@ -23,15 +23,18 @@ trivial patch so apply some common sense
>> 4. When you are happy with a change make it generally available for
>> testing and await feedback.
>>
>> -5. Make a patch available to the relevant maintainer in the list.
>> Use
>> - 'diff -u' to make the patch easy to merge. Be prepared to get
>> your
>> - changes sent back with seemingly silly requests about formatting
>> - and variable names. These aren't as silly as they seem. One
>> - job the maintainers (and especially Linus) do is to keep things
>> +5. Make a patch available to the relevant maintainer(s) and mailing
>> + list(s). Use 'diff -u' to make the patch easy to merge. Be
>> prepared
>> + to get your changes sent back with seemingly silly requests about
>> + formatting and variable names. These aren't as silly as they
>> seem.
>> + One job the maintainers (and especially Linus) do is to keep
>> things
>> looking the same. Sometimes this means that the clever hack in
>> your driver to get around a problem actually needs to become a
>> generalized kernel feature ready for next time.
>>
>> + Use the relevant mailing list(s) -- don't just send everything to
>> + lkml (linux-kernel@vger.kernel.org).
>
> + Always including lkml in addition to more specific lists is
> usually OK.
Well, I'd rather not say that, but that's the type of discussion
that this patch was looking for..
>> +
>> PLEASE check your patch with the automated style checker
>> (scripts/checkpatch.pl) to catch trival style violations.
>> See Documentation/CodingStyle for guidance here.
Thanks.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-07-27 0:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-27 0:08 [PATCH] MAINTAINERS: use relevant mailing lists Randy Dunlap
2007-07-27 0:17 ` Jesper Juhl
2007-07-27 0:31 ` Randy Dunlap [this message]
2007-07-27 0:31 ` Andrew Morton
2007-07-27 17:53 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A93CED.9090002@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox