[PATCH] MAINTAINERS: use relevant mailing lists

[PATCH] MAINTAINERS: use relevant mailing lists

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

Add text on using relevant mailing lists.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 MAINTAINERS |   13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

--- linux-2623-rc1g2.orig/MAINTAINERS
+++ linux-2623-rc1g2/MAINTAINERS
@@ -23,15 +23,18 @@ trivial patch so apply some common sense
 4.	When you are happy with a change make it generally available for
 	testing and await feedback.
 
-5.	Make a patch available to the relevant maintainer in the list. Use
-	'diff -u' to make the patch easy to merge. Be prepared to get your
-	changes sent back with seemingly silly requests about formatting
-	and variable names.  These aren't as silly as they seem. One
-	job the maintainers (and especially Linus) do is to keep things
+5.	Make a patch available to the relevant maintainer(s) and mailing
+	list(s). Use 'diff -u' to make the patch easy to merge. Be prepared
+	to get your changes sent back with seemingly silly requests about
+	formatting and variable names.  These aren't as silly as they seem.
+	One job the maintainers (and especially Linus) do is to keep things
 	looking the same. Sometimes this means that the clever hack in
 	your driver to get around a problem actually needs to become a
 	generalized kernel feature ready for next time.
 
+	Use the relevant mailing list(s) -- don't just send everything to
+	lkml (linux-kernel@vger.kernel.org).
+
 	PLEASE check your patch with the automated style checker
 	(scripts/checkpatch.pl) to catch trival style violations.
 	See Documentation/CodingStyle for guidance here.

Re: [PATCH] MAINTAINERS: use relevant mailing lists

[Jesper Juhl]

On 27/07/07, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Add text on using relevant mailing lists.
>

I'd add a little bit to that - see below

> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  MAINTAINERS |   13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
>
> --- linux-2623-rc1g2.orig/MAINTAINERS
> +++ linux-2623-rc1g2/MAINTAINERS
> @@ -23,15 +23,18 @@ trivial patch so apply some common sense
>  4.     When you are happy with a change make it generally available for
>         testing and await feedback.
>
> -5.     Make a patch available to the relevant maintainer in the list. Use
> -       'diff -u' to make the patch easy to merge. Be prepared to get your
> -       changes sent back with seemingly silly requests about formatting
> -       and variable names.  These aren't as silly as they seem. One
> -       job the maintainers (and especially Linus) do is to keep things
> +5.     Make a patch available to the relevant maintainer(s) and mailing
> +       list(s). Use 'diff -u' to make the patch easy to merge. Be prepared
> +       to get your changes sent back with seemingly silly requests about
> +       formatting and variable names.  These aren't as silly as they seem.
> +       One job the maintainers (and especially Linus) do is to keep things
>         looking the same. Sometimes this means that the clever hack in
>         your driver to get around a problem actually needs to become a
>         generalized kernel feature ready for next time.
>
> +       Use the relevant mailing list(s) -- don't just send everything to
> +       lkml (linux-kernel@vger.kernel.org).

 +       Always including lkml in addition to more specific lists is usually OK.

> +
>         PLEASE check your patch with the automated style checker
>         (scripts/checkpatch.pl) to catch trival style violations.
>         See Documentation/CodingStyle for guidance here.



-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

Re: [PATCH] MAINTAINERS: use relevant mailing lists

[Randy Dunlap]

Jesper Juhl wrote:
> On 27/07/07, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Add text on using relevant mailing lists.
>>
> 
> I'd add a little bit to that - see below
> 
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> ---
>>  MAINTAINERS |   13 ++++++++-----
>>  1 file changed, 8 insertions(+), 5 deletions(-)
>>
>> --- linux-2623-rc1g2.orig/MAINTAINERS
>> +++ linux-2623-rc1g2/MAINTAINERS
>> @@ -23,15 +23,18 @@ trivial patch so apply some common sense
>>  4.     When you are happy with a change make it generally available for
>>         testing and await feedback.
>>
>> -5.     Make a patch available to the relevant maintainer in the list. 
>> Use
>> -       'diff -u' to make the patch easy to merge. Be prepared to get 
>> your
>> -       changes sent back with seemingly silly requests about formatting
>> -       and variable names.  These aren't as silly as they seem. One
>> -       job the maintainers (and especially Linus) do is to keep things
>> +5.     Make a patch available to the relevant maintainer(s) and mailing
>> +       list(s). Use 'diff -u' to make the patch easy to merge. Be 
>> prepared
>> +       to get your changes sent back with seemingly silly requests about
>> +       formatting and variable names.  These aren't as silly as they 
>> seem.
>> +       One job the maintainers (and especially Linus) do is to keep 
>> things
>>         looking the same. Sometimes this means that the clever hack in
>>         your driver to get around a problem actually needs to become a
>>         generalized kernel feature ready for next time.
>>
>> +       Use the relevant mailing list(s) -- don't just send everything to
>> +       lkml (linux-kernel@vger.kernel.org).
> 
> +       Always including lkml in addition to more specific lists is 
> usually OK.

Well, I'd rather not say that, but that's the type of discussion
that this patch was looking for..

>> +
>>         PLEASE check your patch with the automated style checker
>>         (scripts/checkpatch.pl) to catch trival style violations.
>>         See Documentation/CodingStyle for guidance here.

Thanks.
-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: [PATCH] MAINTAINERS: use relevant mailing lists

[Andrew Morton]

On Thu, 26 Jul 2007 17:08:57 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote:

> +	Use the relevant mailing list(s) -- don't just send everything to
> +	lkml (linux-kernel@vger.kernel.org).

True.

I personally only troll lkml for unloved patches, so I suspect that a
random patch which is sent to mailing-list-A and not to lkml has a higher
probability of getting lost than one which is sent to both lists.  Plus
it'd be nice to get lkml's patch-to-noise ratio above one percent.

So I'd suggest that you rework the text here to make it clearer that
patches should go to lkml _and_ to the subsystem-specific mailing list.

Re: [PATCH] MAINTAINERS: use relevant mailing lists

[Randy Dunlap]

On Thu, 26 Jul 2007 17:31:40 -0700 Andrew Morton wrote:

> On Thu, 26 Jul 2007 17:08:57 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote:
> 
> > +	Use the relevant mailing list(s) -- don't just send everything to
> > +	lkml (linux-kernel@vger.kernel.org).
> 
> True.
> 
> I personally only troll lkml for unloved patches, so I suspect that a
> random patch which is sent to mailing-list-A and not to lkml has a higher
> probability of getting lost than one which is sent to both lists.  Plus
> it'd be nice to get lkml's patch-to-noise ratio above one percent.

Yes (to P-N ratio).

I'd really like to see netdev patches going to netdev (only :)
and SCSI patches to linux-scsi (only), e.g., unless they actually
address some linux-arch like issue(s).

However, those maintainers are quite different regarding patch
handling.  Maybe you could try to address some of that at that
Cambridge/September event.

> So I'd suggest that you rework the text here to make it clearer that
> patches should go to lkml _and_ to the subsystem-specific mailing list.

Patch is withdrawn.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***