public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Parag Warudkar <parag.warudkar@gmail.com>
To: linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	akpm@linux-foundation.org
Subject: [PATCH] TSDEV - Don't flood dmesg with removal warnings
Date: Fri, 27 Jul 2007 10:09:20 -0400	[thread overview]
Message-ID: <46A9FC90.7080307@gmail.com> (raw)

tsdev.c warns about scheduled removal each time tsdev_open is called - 
So even for a default boot I get to see the warning 3 times -

[  340.537078] tsdev (compaq touchscreen emulation) is scheduled for 
removal.
[  340.537081] See Documentation/feature-removal-schedule.txt for details.
[  340.550314] tsdev (compaq touchscreen emulation) is scheduled for 
removal.
[  340.550318] See Documentation/feature-removal-schedule.txt for details.
[  340.565065] tsdev (compaq touchscreen emulation) is scheduled for 
removal.
[  340.565068] See Documentation/feature-removal-schedule.txt for details.

Move the warning to tsdev_init() from tsdev_open so we don't end up 
printing a large string in dmesg everytime tsdev_open is called.

Signed-Off-by: Parag Warudkar <parag.warudkar@gmail.com>

--- linux-git/drivers/input/tsdev.c.orig    2007-07-27 
09:57:14.000000000 -0400
+++ linux-git/drivers/input/tsdev.c    2007-07-27 09:58:09.000000000 -0400
@@ -154,10 +154,6 @@
     struct tsdev *tsdev;
     int error;
 
-    printk(KERN_WARNING "tsdev (compaq touchscreen emulation) is 
scheduled "
-        "for removal.\nSee Documentation/feature-removal-schedule.txt "
-        "for details.\n");
-
     if (i >= TSDEV_MINORS)
         return -ENODEV;
 
@@ -521,6 +517,9 @@
 
 static int __init tsdev_init(void)
 {
+    printk(KERN_WARNING "tsdev (compaq touchscreen emulation) is 
scheduled "
+        "for removal.\nSee Documentation/feature-removal-schedule.txt "
+        "for details.\n");
     return input_register_handler(&tsdev_handler);
 }

             reply	other threads:[~2007-07-27 14:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-27 14:09 Parag Warudkar [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-07-27 14:43 [PATCH] TSDEV - Don't flood dmesg with removal warnings Parag Warudkar
2007-07-29  4:37 ` Dmitry Torokhov
2007-07-29 13:58   ` Parag Warudkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46A9FC90.7080307@gmail.com \
    --to=parag.warudkar@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox