From: "Chris Friesen" <cfriesen@nortel.com>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: LinuxPPS & spinlocks
Date: Fri, 27 Jul 2007 13:40:14 -0600 [thread overview]
Message-ID: <46AA4A1E.8040302@nortel.com> (raw)
In-Reply-To: <20070727192848.GW9840@enneenne.com>
Rodolfo Giometti wrote:
> What do you mean? Did you find an error into my patch? :-o
>
> Functions pps_event() and
> pps_register_source()/pps_unregister_source() take accesso to shared
> data, that's why I used spinlocks.
My point is that the lock should be used to protect specific data.
Thus, it would be more correct to say, "spinlock foo is taken because
pps_register_source() accesses variable bar".
That way, if someone else wants to access "bar", they know that they
need to take lock "foo".
Chris
next prev parent reply other threads:[~2007-07-27 19:40 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 18:05 [PATCH] LinuxPPS - definitive version Rodolfo Giometti
2007-07-23 13:35 ` David Woodhouse
2007-07-23 16:04 ` Rodolfo Giometti
2007-07-23 19:28 ` Andrew Morton
2007-07-23 19:48 ` David Woodhouse
2007-07-24 8:00 ` Rodolfo Giometti
2007-07-24 13:49 ` David Woodhouse
2007-07-24 14:20 ` Rodolfo Giometti
2007-07-24 14:46 ` David Woodhouse
2007-07-24 14:52 ` David Woodhouse
2007-07-24 16:01 ` Rodolfo Giometti
2007-07-27 18:44 ` LinuxPPS & spinlocks Rodolfo Giometti
2007-07-27 19:08 ` Chris Friesen
2007-07-27 19:28 ` Rodolfo Giometti
2007-07-27 19:40 ` Chris Friesen [this message]
2007-07-27 19:45 ` Rodolfo Giometti
2007-07-27 20:47 ` Satyam Sharma
2007-07-27 23:41 ` Satyam Sharma
2007-07-29 9:50 ` Rodolfo Giometti
2007-07-30 5:03 ` Satyam Sharma
2007-07-30 8:51 ` Rodolfo Giometti
2007-07-30 9:20 ` Satyam Sharma
2007-08-01 22:14 ` Christopher Hoover
2007-08-01 23:03 ` Satyam Sharma
2007-07-29 9:57 ` Rodolfo Giometti
2007-07-29 10:00 ` Rodolfo Giometti
2007-07-30 5:09 ` Satyam Sharma
2007-07-30 8:53 ` Rodolfo Giometti
2007-07-30 9:31 ` Satyam Sharma
2007-07-29 9:17 ` Rodolfo Giometti
2007-07-30 4:19 ` Satyam Sharma
2007-07-30 8:32 ` Rodolfo Giometti
2007-07-30 9:07 ` Satyam Sharma
2007-07-30 14:55 ` Rodolfo Giometti
2007-07-30 22:01 ` Satyam Sharma
2007-07-31 8:20 ` Rodolfo Giometti
2007-07-31 18:49 ` Satyam Sharma
2007-07-31 19:44 ` Rodolfo Giometti
2007-07-31 21:15 ` Satyam Sharma
2007-07-24 14:31 ` [PATCH] LinuxPPS - definitive version Rodolfo Giometti
2007-07-24 14:45 ` David Woodhouse
2007-07-24 16:09 ` Rodolfo Giometti
2007-07-26 19:52 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AA4A1E.8040302@nortel.com \
--to=cfriesen@nortel.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=giometti@enneenne.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox