From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
martin.pitt@ubuntu.com, wwoods@redhat.com
Subject: Re: [PATCH 2/3] core_pattern: allow passing of arguments to user mode helper when core_pattern is a pipe
Date: Fri, 27 Jul 2007 13:54:19 -0700 [thread overview]
Message-ID: <46AA5B7B.7040406@goop.org> (raw)
In-Reply-To: <20070727200746.GC18946@hmsreliant.homelinux.net>
Neil Horman wrote:
> + int helper_argc = 0;
>
> + helper_argv = argv_split(GFP_KERNEL, corename+1, &helper_argc);
>
Hm, I suspect most users of argv_split don't really care about argc, so
it would useful to change argv_split to take NULL as the argc pointer,
rather than declare a bunch of unused variables. Interested in throwing
a patch together?
J
next prev parent reply other threads:[~2007-07-27 20:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-27 20:08 [PATCH 2/3] core_pattern: allow passing of arguments to user mode helper when core_pattern is a pipe Neil Horman
2007-07-27 20:54 ` Jeremy Fitzhardinge [this message]
2007-07-28 0:46 ` Neil Horman
2007-07-28 9:23 ` Martin Pitt
2007-07-28 13:46 ` Neil Horman
2007-07-28 16:17 ` Martin Pitt
2007-07-28 17:21 ` Neil Horman
2007-07-28 22:52 ` Jeremy Fitzhardinge
2007-07-29 2:21 ` Neil Horman
2007-07-29 8:53 ` Aneesh Kumar K.V
2007-07-29 12:16 ` Neil Horman
2007-07-29 9:34 ` Martin Pitt
2007-07-29 12:19 ` Neil Horman
2007-07-29 13:03 ` Eugene Teo
2007-07-29 21:58 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AA5B7B.7040406@goop.org \
--to=jeremy@goop.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.pitt@ubuntu.com \
--cc=nhorman@tuxdriver.com \
--cc=wwoods@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox