From: Michael Krufky <mkrufky@linuxtv.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: v4l-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org
Subject: Re: [v4l-dvb-maintainer] [2.6 patch] make struct dvb_pll_fcv1236d static
Date: Sun, 29 Jul 2007 11:37:24 -0400 [thread overview]
Message-ID: <46ACB434.2040007@linuxtv.org> (raw)
In-Reply-To: <20070729145705.GK16817@stusta.de>
Adrian Bunk wrote:
> struct dvb_pll_fcv1236d can become static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
> --- linux-2.6.23-rc1-mm1/drivers/media/dvb/frontends/dvb-pll.c.old 2007-07-26 09:04:23.000000000 +0200
> +++ linux-2.6.23-rc1-mm1/drivers/media/dvb/frontends/dvb-pll.c 2007-07-26 09:04:32.000000000 +0200
> @@ -501,7 +501,7 @@
>
> /* Philips FCV1236D
> */
> -struct dvb_pll_desc dvb_pll_fcv1236d = {
> +static struct dvb_pll_desc dvb_pll_fcv1236d = {
> /* Bit_0: RF Input select
> * Bit_1: 0=digital, 1=analog
> */
>
Oops. I created that patch before the "dvb: remove static dependencies
on dvb-pll" patch was applied, but the fcv1236d patch didn't get merged
until after the fact. Thanks for the fix, Adrian. I'll apply this.
Regards,
Mike Krufky
prev parent reply other threads:[~2007-07-29 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 14:57 [2.6 patch] make struct dvb_pll_fcv1236d static Adrian Bunk
2007-07-29 15:37 ` Michael Krufky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46ACB434.2040007@linuxtv.org \
--to=mkrufky@linuxtv.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox