From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: Adrian Bunk <bunk@stusta.de>
Cc: "Mark M. Hoffman" <mhoffman@lightlink.com>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [2.6 patch] make abituguru3_read_increment_offset() static
Date: Sun, 29 Jul 2007 18:08:46 +0200 [thread overview]
Message-ID: <46ACBB8E.9080302@hhs.nl> (raw)
In-Reply-To: <20070729145701.GJ16817@stusta.de>
Adrian Bunk wrote:
> abituguru3_read_increment_offset() can become static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Looks good, good catch.
Acked-by: Hans de Goede <j.w.r.degoede@hhs.nl>
>
> ---
> --- linux-2.6.23-rc1-mm1/drivers/hwmon/abituguru3.c.old 2007-07-26 08:56:33.000000000 +0200
> +++ linux-2.6.23-rc1-mm1/drivers/hwmon/abituguru3.c 2007-07-26 08:57:00.000000000 +0200
> @@ -691,8 +691,9 @@
>
> /* Sensor settings are stored 1 byte per offset with the bytes
> placed add consecutive offsets. */
> -int abituguru3_read_increment_offset(struct abituguru3_data *data, u8 bank,
> - u8 offset, u8 count, u8 *buf, int offset_count)
> +static int abituguru3_read_increment_offset(struct abituguru3_data *data,
> + u8 bank, u8 offset, u8 count,
> + u8 *buf, int offset_count)
> {
> int i, x;
>
>
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
>
next prev parent reply other threads:[~2007-07-29 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 14:57 [2.6 patch] make abituguru3_read_increment_offset() static Adrian Bunk
2007-07-29 16:08 ` Hans de Goede [this message]
2007-07-29 18:45 ` [lm-sensors] " Mark M. Hoffman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46ACBB8E.9080302@hhs.nl \
--to=j.w.r.degoede@hhs.nl \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox