From: Greg Ungerer <gerg@snapgear.com>
To: Yoann Padioleau <padator@wanadoo.fr>
Cc: kernel-janitors@vger.kernel.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/68] 0 -> NULL, for arch/m68knommu
Date: Mon, 30 Jul 2007 10:40:23 +1000 [thread overview]
Message-ID: <46AD3377.6020909@snapgear.com> (raw)
In-Reply-To: <200707270944.LAA17230@ifs.emn.fr>
Hi Yoann,
Yoann Padioleau wrote:
> When comparing a pointer, it's clearer to compare it to NULL than to 0.
>
> Signed-off-by: Yoann Padioleau <padator@wanadoo.fr>
> Cc: gerg@uclinux.org
Acked-by: Greg Ungerer <gerg@uclinux.org>
> Cc: akpm@linux-foundation.org
> ---
>
> comempci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/m68knommu/kernel/comempci.c b/arch/m68knommu/kernel/comempci.c
> index 6ee00ef..528517e 100644
> --- a/arch/m68knommu/kernel/comempci.c
> +++ b/arch/m68knommu/kernel/comempci.c
> @@ -736,7 +736,7 @@ #endif
>
> /* Find a free spot to put this handler */
> for (i = 0; (i < COMEM_MAXPCI); i++) {
> - if (pci_irqlist[i].handler == 0) {
> + if (pci_irqlist[i].handler == NULL) {
> pci_irqlist[i].handler = handler;
> pci_irqlist[i].device = device;
> pci_irqlist[i].dev_id = dev_id;
>
>
--
------------------------------------------------------------------------
Greg Ungerer -- Chief Software Dude EMAIL: gerg@snapgear.com
Secure Computing Corporation PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
prev parent reply other threads:[~2007-07-30 0:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-27 9:44 [PATCH 09/68] 0 -> NULL, for arch/m68knommu Yoann Padioleau
2007-07-30 0:40 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AD3377.6020909@snapgear.com \
--to=gerg@snapgear.com \
--cc=akpm@linux-foundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=padator@wanadoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox