From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937397AbXG3BEV (ORCPT ); Sun, 29 Jul 2007 21:04:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934959AbXG3BEO (ORCPT ); Sun, 29 Jul 2007 21:04:14 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:38803 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933615AbXG3BEN (ORCPT ); Sun, 29 Jul 2007 21:04:13 -0400 Message-ID: <46AD390B.2080400@garzik.org> Date: Sun, 29 Jul 2007 21:04:11 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.12 (X11/20070719) MIME-Version: 1.0 To: James Bottomley CC: Andrew Morton , Linus Torvalds , linux-scsi , linux-kernel Subject: Re: [GIT PATCH] SCSI bug fixes for 2.6.23-rc1 References: <1185720592.3434.7.camel@localhost.localdomain> <46AD19F7.7040905@garzik.org> <1185756759.3434.19.camel@localhost.localdomain> In-Reply-To: <1185756759.3434.19.camel@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.9 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org James Bottomley wrote: > msleep_interruptible -> ssleep is a > change with zero practical impact for this driver, eh, how do you figure? A signal can clearly cause the abort-related functions to delay far shorter than the driver wishes. The msleep_interruptible() in arcmsr_wait_msgint_ready() probably isn't fatal -- unless it's there to ensure the hardware isn't pounded -- but again, a signal can cause a CPU-wasting busy loop that could last for quite a while (in CPU terms). Jeff