* checkpatch.pl false positive on exported pointers
@ 2007-07-29 16:28 Dan Williams
2007-07-30 9:34 ` Andy Whitcroft
0 siblings, 1 reply; 2+ messages in thread
From: Dan Williams @ 2007-07-29 16:28 UTC (permalink / raw)
To: apw, rdunlap, jschopp; +Cc: lkml
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#563: FILE: drivers/scsi/iioc34x/iioc34x_sas.c:58:
+EXPORT_SYMBOL(iioc34x_transport_template);
drivers/scsi/iioc34x/iioc34x_sas.c:57
struct scsi_transport_template *iioc34x_transport_template;
EXPORT_SYMBOL(iioc34x_transport_template);
I suspect the script wants:
EXPORT_SYMBOL(*iioc34x_transport_template);
...but that does not compile.
Thanks,
Dan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: checkpatch.pl false positive on exported pointers
2007-07-29 16:28 checkpatch.pl false positive on exported pointers Dan Williams
@ 2007-07-30 9:34 ` Andy Whitcroft
0 siblings, 0 replies; 2+ messages in thread
From: Andy Whitcroft @ 2007-07-30 9:34 UTC (permalink / raw)
To: Dan Williams; +Cc: rdunlap, jschopp, lkml
Dan Williams wrote:
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> #563: FILE: drivers/scsi/iioc34x/iioc34x_sas.c:58:
> +EXPORT_SYMBOL(iioc34x_transport_template);
>
> drivers/scsi/iioc34x/iioc34x_sas.c:57
> struct scsi_transport_template *iioc34x_transport_template;
> EXPORT_SYMBOL(iioc34x_transport_template);
>
> I suspect the script wants:
> EXPORT_SYMBOL(*iioc34x_transport_template);
> ...but that does not compile.
Thanks for the report. Will look into this for the next update.
-apw
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-30 9:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-29 16:28 checkpatch.pl false positive on exported pointers Dan Williams
2007-07-30 9:34 ` Andy Whitcroft
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox