From: Eugene Teo <eugeneteo@kernel.sg>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/partitions/check.c: add_partition() warning fixes
Date: Mon, 30 Jul 2007 17:43:38 +0800 [thread overview]
Message-ID: <46ADB2CA.3070107@kernel.sg> (raw)
In-Reply-To: <20070730110831.68075b30@gondolin.boeblingen.de.ibm.com>
Hi Cornelia,
Cornelia Huck wrote:
> On Sun, 29 Jul 2007 10:53:39 +0800,
> Eugene Teo <eugeneteo@kernel.sg> wrote:
[...]
>> + return;
>> +
>> +err_out_del_link:
>> + sysfs_remove_link(&p->kobj, "subsystem");
>
> You need a remove uevent if you did an add uevent above.
>
>> +err_out_del_kobj:
>> + kobject_del(&p->kobj);
>> +err_out:
>> + kfree(p);
>
> Please use kobject_put() instead.
Thanks for your feedback.
Eugene
prev parent reply other threads:[~2007-07-30 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 2:53 [PATCH] fs/partitions/check.c: add_partition() warning fixes Eugene Teo
2007-07-30 9:08 ` Cornelia Huck
2007-07-30 9:43 ` Eugene Teo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46ADB2CA.3070107@kernel.sg \
--to=eugeneteo@kernel.sg \
--cc=cornelia.huck@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox