From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939681AbXG3T7x (ORCPT ); Mon, 30 Jul 2007 15:59:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S938815AbXG3T72 (ORCPT ); Mon, 30 Jul 2007 15:59:28 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:33887 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937744AbXG3T71 (ORCPT ); Mon, 30 Jul 2007 15:59:27 -0400 Message-ID: <46AE431D.2000808@garzik.org> Date: Mon, 30 Jul 2007 15:59:25 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.12 (X11/20070719) MIME-Version: 1.0 To: Micah Gruber CC: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] [2.6.22] Fix a potential NULL pointer dereference in mace_interrupt() in drivers/net/pcmcia/nmclan_cs.c References: <46A567A8.6050409@gmail.com> In-Reply-To: <46A567A8.6050409@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.9 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Micah Gruber wrote: > This patch fixes a potential null dereference bug where we dereference > DEV before a null check. This patch simply moves the dereferencing after > the null check. > > Signed-off-by: Micah Gruber applied (git-am worked!)