Re: Linus 2.6.23-rc1

Bob Picco
2007-07-23T15:48:16Z

Gabriel C wrote: [Sun Jul 22 2007, 10:00:39PM EDT]
> Linus Torvalds wrote:
> > Ok, right on time, two weeks afetr 2.6.22, there's a 2.6.23-rc1 out there.
>
>
> ...
>
> drivers/char/hpet.c:76: warning: integer constant is too large for 'long' type
>
> ...
>
> Introduced by 0aa366f351d044703e25c8425e508170e80d83b1
>
>
>
>

Sorry about that. I thought my review had caught all of these.

Signed-off-by: Bob Picco <bob.picco@hp.com>

drivers/char/hpet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.23-rc1/drivers/char/hpet.c
===================================================================
--- linux-2.6.23-rc1.orig/drivers/char/hpet.c 2007-07-23 10:08:58.000000000 -0400
+++ linux-2.6.23-rc1/drivers/char/hpet.c 2007-07-23 11:46:12.000000000 -0400
@@ -73,7 +73,7 @@ static struct clocksource clocksource_hp
.name = "hpet",
.rating = 250,
.read = read_hpet,
- .mask = 0xffffffffffffffff,
+ .mask = 0xffffffffffffffffULL,
.mult = 0, /*to be caluclated*/
.shift = 10,
.flags = CLOCK_SOURCE_IS_CONTINUOUS,