Re: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()

Linus Torvalds
2007-07-24T18:14:58Z

On Tue, 24 Jul 2007, Adrian Bunk wrote:
>
> buffered_rmqueue() and prep_new_page() are static functions with only
> one caller each, and for the normal non-debug case it's a really nice
> optimization to have them inlined automatically.

I'm not at all sure I agree.

Inlining big functions doesn't actually tend to generally generate any
better code, so if gcc's logic is "single callsite - always inline", then
that logic is likely not right.

Linus