From: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
To: Christoph Hellwig <hch@infradead.org>,
Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-scsi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] Coding style fix drivers/scsi/aha1542.c
Date: Wed, 01 Aug 2007 17:22:31 +0200 [thread overview]
Message-ID: <46B0A537.9070907@googlemail.com> (raw)
In-Reply-To: <20070801151812.GA17601@infradead.org>
Christoph Hellwig pisze:
> On Wed, Aug 01, 2007 at 05:13:14PM +0200, Michal Piotrowski wrote:
>> Hi,
>>
>> Coding style fix
>>
>> Regards,
>> Michal
>>
>
> I think that include should just go. There is no reason at all for
> a scsi driver to include stat.h
>
>
As you wish
Regards,
Michal
--
LOG
http://www.stardust.webpages.pl/log/
Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
--- linux-mm-clean/drivers/scsi/aha1542.c 2007-07-09 01:32:17.000000000 +0200
+++ linux-mm/drivers/scsi/aha1542.c 2007-08-01 17:18:57.000000000 +0200
@@ -77,8 +77,6 @@ static void BAD_SG_DMA(Scsi_Cmnd * SCpnt
panic("Buffer at physical address > 16Mb used for aha1542");
}
-#include<linux/stat.h>
-
#ifdef DEBUG
#define DEB(x) x
#else
prev parent reply other threads:[~2007-08-01 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 15:13 [RFC][PATCH] Coding style fix drivers/scsi/aha1542.c Michal Piotrowski
2007-08-01 15:18 ` Christoph Hellwig
2007-08-01 15:22 ` Michal Piotrowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B0A537.9070907@googlemail.com \
--to=michal.k.k.piotrowski@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox