* [RFC][PATCH] Coding style fix drivers/scsi/aha1542.c
@ 2007-08-01 15:13 Michal Piotrowski
2007-08-01 15:18 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Michal Piotrowski @ 2007-08-01 15:13 UTC (permalink / raw)
To: Andrew Morton, linux-scsi, LKML
Hi,
Coding style fix
Regards,
Michal
--
LOG
http://www.stardust.webpages.pl/log/
Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
--- linux-mm-clean/drivers/scsi/aha1542.c 2007-07-09 01:32:17.000000000 +0200
+++ linux-mm/drivers/scsi/aha1542.c 2007-08-01 17:09:40.000000000 +0200
@@ -77,7 +77,7 @@ static void BAD_SG_DMA(Scsi_Cmnd * SCpnt
panic("Buffer at physical address > 16Mb used for aha1542");
}
-#include<linux/stat.h>
+#include <linux/stat.h>
#ifdef DEBUG
#define DEB(x) x
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC][PATCH] Coding style fix drivers/scsi/aha1542.c
2007-08-01 15:13 [RFC][PATCH] Coding style fix drivers/scsi/aha1542.c Michal Piotrowski
@ 2007-08-01 15:18 ` Christoph Hellwig
2007-08-01 15:22 ` Michal Piotrowski
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2007-08-01 15:18 UTC (permalink / raw)
To: Michal Piotrowski; +Cc: Andrew Morton, linux-scsi, LKML
On Wed, Aug 01, 2007 at 05:13:14PM +0200, Michal Piotrowski wrote:
> Hi,
>
> Coding style fix
>
> Regards,
> Michal
>
I think that include should just go. There is no reason at all for
a scsi driver to include stat.h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC][PATCH] Coding style fix drivers/scsi/aha1542.c
2007-08-01 15:18 ` Christoph Hellwig
@ 2007-08-01 15:22 ` Michal Piotrowski
0 siblings, 0 replies; 3+ messages in thread
From: Michal Piotrowski @ 2007-08-01 15:22 UTC (permalink / raw)
To: Christoph Hellwig, Michal Piotrowski, Andrew Morton, linux-scsi,
LKML
Christoph Hellwig pisze:
> On Wed, Aug 01, 2007 at 05:13:14PM +0200, Michal Piotrowski wrote:
>> Hi,
>>
>> Coding style fix
>>
>> Regards,
>> Michal
>>
>
> I think that include should just go. There is no reason at all for
> a scsi driver to include stat.h
>
>
As you wish
Regards,
Michal
--
LOG
http://www.stardust.webpages.pl/log/
Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
--- linux-mm-clean/drivers/scsi/aha1542.c 2007-07-09 01:32:17.000000000 +0200
+++ linux-mm/drivers/scsi/aha1542.c 2007-08-01 17:18:57.000000000 +0200
@@ -77,8 +77,6 @@ static void BAD_SG_DMA(Scsi_Cmnd * SCpnt
panic("Buffer at physical address > 16Mb used for aha1542");
}
-#include<linux/stat.h>
-
#ifdef DEBUG
#define DEB(x) x
#else
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-01 15:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-01 15:13 [RFC][PATCH] Coding style fix drivers/scsi/aha1542.c Michal Piotrowski
2007-08-01 15:18 ` Christoph Hellwig
2007-08-01 15:22 ` Michal Piotrowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox