From: "H. Peter Anvin" <hpa@zytor.com>
To: "Antonino A. Daplas" <adaplas@gmail.com>
Cc: Daniel Drake <dsd@gentoo.org>,
Zwane Mwaikambo <zwane@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jan Beulich <jbeulich@novell.com>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@suse.de>
Subject: Re: [PATCH] retrieve VBE EDID/DDC info independent of used video mode
Date: Thu, 02 Aug 2007 09:23:06 -0400 [thread overview]
Message-ID: <46B1DABA.3090800@zytor.com> (raw)
In-Reply-To: <46B1AF0E.40703@gmail.com>
Antonino A. Daplas wrote:
>
> How about this patch?
>
> Tony
> ---
>
> Subject: video setup: Fix VBE DDC reading
>
> Add memory operand constraint and write-only modifier to the inline
> assembly to effect the writing of the EDID block to boot_params.edid_info.
>
> Signed-off-by: Antonino Daplas <adaplas@gmail.com>
OK, now I feel dumb. You're absolutely right; without that constraint,
the entire EDID function after the memset is eliminated by gcc as being
dead code.
Will queue the patch.
-hpa
next prev parent reply other threads:[~2007-08-02 13:30 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 15:57 [PATCH] retrieve VBE EDID/DDC info independent of used video mode Jan Beulich
2007-06-30 22:25 ` Daniel Drake
2007-06-30 22:42 ` Andrew Morton
2007-07-08 13:27 ` Daniel Drake
2007-07-08 18:14 ` Andrew Morton
2007-07-08 18:33 ` H. Peter Anvin
2007-07-09 22:53 ` Daniel Drake
2007-07-09 22:59 ` H. Peter Anvin
2007-07-10 17:16 ` Daniel Drake
2007-07-10 17:23 ` H. Peter Anvin
2007-07-10 18:07 ` Daniel Drake
2007-07-10 18:15 ` H. Peter Anvin
2007-07-31 23:58 ` Daniel Drake
2007-08-01 0:21 ` Zwane Mwaikambo
2007-08-01 1:17 ` Daniel Drake
2007-08-01 1:53 ` H. Peter Anvin
2007-08-01 1:54 ` Antonino A. Daplas
2007-08-01 2:08 ` Gabriel C
2007-08-02 3:09 ` Antonino A. Daplas
2007-08-02 3:50 ` H. Peter Anvin
2007-08-02 10:16 ` Antonino A. Daplas
2007-08-02 13:23 ` H. Peter Anvin [this message]
2007-08-03 2:33 ` Daniel Drake
2007-08-03 3:33 ` Antonino A. Daplas
2007-08-01 1:04 ` Antonino A. Daplas
2007-07-08 19:48 ` Andi Kleen
2007-07-09 1:10 ` Daniel Drake
2007-07-09 0:48 ` H. Peter Anvin
2007-07-02 20:13 ` Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B1DABA.3090800@zytor.com \
--to=hpa@zytor.com \
--cc=adaplas@gmail.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dsd@gentoo.org \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox