public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Hancock <hancockr@shaw.ca>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Andi Kleen <andi@firstfloor.org>, linux-kernel@vger.kernel.org
Subject: Re: gcc fixed size char array initialization bug - known?
Date: Thu, 02 Aug 2007 15:42:29 -0600	[thread overview]
Message-ID: <46B24FC5.8060409@shaw.ca> (raw)
In-Reply-To: <fa.cjPWb5ZShF43DhggNXkMKMadPYY@ifi.uio.no>

Guennadi Liakhovetski wrote:
> On Thu, 2 Aug 2007, Andi Kleen wrote:
> 
>> Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:
>>
>>> 	char c[4] = "0123";
>>> and - a wonder - no warning. 
>> It's required by the C standard.
>>
>> 6.7.8.14 of C99:
>> ``
>> An array of character type may be initialized by a character string literal, optionally
>> enclosed in braces. Successive characters of the character string literal (including the
>> terminating null character if there is room or if the array is of unknown size) initialize the
>> elements of the array.
>> ''
>>
>> Note the "if there is room".
>>
>> I believe the rationale is that it still allows to conveniently initialize 
>> non zero terminated strings.
> 
> Right, I accept that it will compile, but I don't understand why "01234" 
> produces a warning and "0123" doesn't? Don't think C99 says anything about 

Because 5 characters will not fit in a 4 character array, even without 
the null terminator.

> that. And, AFAIU, using structs with fixed-size char array we more or less 
> rely on the compiler warning us if anyone initializes it with too long a 
> string.
> 
> Also interesting, that with
> 
> 	char c[4] = "012345";
> 
> the compiler warns, but actually allocates a 6-byte long array...
> 
> Thanks
> Guennadi


-- 
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/


       reply	other threads:[~2007-08-02 21:42 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.LxMYkBaN628VuktB9CFi9SC3LTA@ifi.uio.no>
     [not found] ` <fa.6wYNfcIjXc+jXzdUGE5gFFOal1g@ifi.uio.no>
     [not found]   ` <fa.cjPWb5ZShF43DhggNXkMKMadPYY@ifi.uio.no>
2007-08-02 21:42     ` Robert Hancock [this message]
2007-08-02 19:55 gcc fixed size char array initialization bug - known? Guennadi Liakhovetski
2007-08-02 19:59 ` Jan Engelhardt
2007-08-02 20:03   ` Jesper Juhl
2007-08-02 20:10     ` Al Viro
2007-08-02 20:12       ` Jesper Juhl
2007-08-02 20:15     ` Guennadi Liakhovetski
2007-08-03  3:17   ` Satyam Sharma
2007-08-03  3:40     ` WANG Cong
2007-08-03  7:32       ` Bernd Petrovitsch
2007-08-02 20:08 ` Al Viro
2007-08-02 20:21   ` Guennadi Liakhovetski
2007-08-02 20:26   ` Guennadi Liakhovetski
2007-08-02 21:09     ` Al Viro
2007-08-02 21:26       ` Guennadi Liakhovetski
2007-08-02 20:18 ` Jan Engelhardt
2007-08-02 21:06 ` Andi Kleen
2007-08-02 20:36   ` Guennadi Liakhovetski
2007-08-02 22:15     ` Stefan Richter
2007-08-02 22:36       ` Guennadi Liakhovetski
2007-08-02 22:54         ` Randy Dunlap
2007-08-02 23:03           ` Al Viro
2007-08-02 23:26           ` Guennadi Liakhovetski
2007-08-02 23:34             ` Rene Herman
2007-08-03  5:00             ` Carlo Florendo
2007-08-02 23:02         ` Al Viro
2007-08-03  4:57         ` Carlo Florendo
2007-08-02 22:31     ` Stefan Richter
2007-08-02 22:51       ` Guennadi Liakhovetski
2007-08-02 23:09         ` Al Viro
2007-08-02 23:27           ` Stefan Richter
2007-08-02 23:30           ` Guennadi Liakhovetski
2007-08-03  7:56             ` Jan Engelhardt
2007-08-03 14:04           ` Alexander van Heukelum
2007-08-02 23:42 ` Jakub Jelinek
2007-08-03 15:16   ` Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B24FC5.8060409@shaw.ca \
    --to=hancockr@shaw.ca \
    --cc=andi@firstfloor.org \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox