From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Andi Kleen <andi@firstfloor.org>, linux-kernel@vger.kernel.org
Subject: Re: gcc fixed size char array initialization bug - known?
Date: Fri, 03 Aug 2007 00:15:38 +0200 [thread overview]
Message-ID: <46B2578A.805@s5r6.in-berlin.de> (raw)
In-Reply-To: <Pine.LNX.4.60.0708022231160.6774@poirot.grange>
Guennadi Liakhovetski wrote:
> On Thu, 2 Aug 2007, Andi Kleen wrote:
>> 6.7.8.14 of C99:
>> ``
>> An array of character type may be initialized by a character string literal, optionally
>> enclosed in braces. Successive characters of the character string literal (including the
>> terminating null character if there is room or if the array is of unknown size) initialize the
>> elements of the array.
>> ''
>>
>> Note the "if there is room".
>>
>> I believe the rationale is that it still allows to conveniently initialize
>> non zero terminated strings.
>
> Right, I accept that it will compile, but I don't understand why "01234"
> produces a warning and "0123" doesn't? Don't think C99 says anything about
How should gcc know whether you actually wanted that char foo[len] to
contain a \0 as last element?
Given the respective command line switches, gcc does warn in some cases
where it is guesswork whether what you typed is what you intended. For
example
if (i = j())
is reason for gcc to warn even if that might exactly be what you wanted.
However this construct can easily be annotated as
if ((i = j()))
to show to gcc and to carbon-based bipedals that you indeed wanted this.
Now there is no nice way to make an annotation that says "look, I'm
going to initialize an array of char with a string literal now, and the
resulting array will contain a non-zero member as last element, and I
mean it". And since there is no such annotation possible, gcc does not
warn and demand that you annotate the perfectly valid and 100%
spec-compliant construct char a[4] = "1234";.
--
Stefan Richter
-=====-=-=== =--- ---==
http://arcgraph.de/sr/
next prev parent reply other threads:[~2007-08-02 22:15 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-02 19:55 gcc fixed size char array initialization bug - known? Guennadi Liakhovetski
2007-08-02 19:59 ` Jan Engelhardt
2007-08-02 20:03 ` Jesper Juhl
2007-08-02 20:10 ` Al Viro
2007-08-02 20:12 ` Jesper Juhl
2007-08-02 20:15 ` Guennadi Liakhovetski
2007-08-03 3:17 ` Satyam Sharma
2007-08-03 3:40 ` WANG Cong
2007-08-03 7:32 ` Bernd Petrovitsch
2007-08-02 20:08 ` Al Viro
2007-08-02 20:21 ` Guennadi Liakhovetski
2007-08-02 20:26 ` Guennadi Liakhovetski
2007-08-02 21:09 ` Al Viro
2007-08-02 21:26 ` Guennadi Liakhovetski
2007-08-02 20:18 ` Jan Engelhardt
2007-08-02 21:06 ` Andi Kleen
2007-08-02 20:36 ` Guennadi Liakhovetski
2007-08-02 22:15 ` Stefan Richter [this message]
2007-08-02 22:36 ` Guennadi Liakhovetski
2007-08-02 22:42 ` (off-topic) " Stefan Richter
2007-08-02 22:54 ` Randy Dunlap
2007-08-02 23:03 ` Al Viro
2007-08-02 23:26 ` Guennadi Liakhovetski
2007-08-02 23:34 ` Rene Herman
2007-08-03 5:00 ` Carlo Florendo
2007-08-02 23:02 ` Al Viro
2007-08-03 4:57 ` Carlo Florendo
2007-08-02 22:31 ` Stefan Richter
2007-08-02 22:51 ` Guennadi Liakhovetski
2007-08-02 23:09 ` Al Viro
2007-08-02 23:27 ` Stefan Richter
2007-08-02 23:30 ` Guennadi Liakhovetski
2007-08-03 7:56 ` Jan Engelhardt
2007-08-03 14:04 ` Alexander van Heukelum
2007-08-02 23:42 ` Jakub Jelinek
2007-08-03 15:16 ` Stefan Richter
[not found] <fa.LxMYkBaN628VuktB9CFi9SC3LTA@ifi.uio.no>
[not found] ` <fa.6wYNfcIjXc+jXzdUGE5gFFOal1g@ifi.uio.no>
[not found] ` <fa.cjPWb5ZShF43DhggNXkMKMadPYY@ifi.uio.no>
2007-08-02 21:42 ` Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B2578A.805@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=andi@firstfloor.org \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox