Re: Forward port of latest RT patch (2.6.21.5-rt20) to 2.6.22 available

Re: Forward port of latest RT patch (2.6.21.5-rt20) to 2.6.22 available

[Gregory Haskins]

On Thu, 2007-07-12 at 14:07 +0200, Ingo Molnar wrote:
> * Gregory Haskins <ghaskins@novell.com> wrote:
> 
> > Hi Ingo, Thomas, and the greater linux-rt community,
> >   
> > 	I just wanted to let you guys know that our team has a port of 
> > the 21.5-rt20 patch for the 2.6.22 kernel available. [...]
> 
> great! We had the upstream -rt port to .22 in the works too, it was just 
> held up by the hpet breakage - which Thomas managed to fix earlier 
> today. I've released the 2.6.22.1-rt1 patch to the usual place:
> 
>     http://redhat.com/~mingo/realtime-preempt/

Thats awesome, Ingo!  Thanks!  Could you publish a broken out version as
well?  We found it extremely valuable to be able to bisect this beast
while working on the 21-22 port.

> 
> I took a quick look at the delta between .22.1-rt1 and your rt1 merge, 
> and the delta patch is quite large and i saw no obvious fixes to pick 
> up. Could you please filter out any fixes that you might have in your 
> tree that you think should be applied, and send it to us as a delta 
> against .22.1-rt1? 

Will do


> (And, as Daniel suggested, in the future, could you _please_ use a 
> different naming scheme instead of using up the upstream -rt namespace.)

Yeah, sorry about that.

-Greg

Re: Forward port of latest RT patch (2.6.21.5-rt20) to 2.6.22 available

[Ingo Molnar]

* Gregory Haskins <ghaskins@novell.com> wrote:

> On Thu, 2007-07-12 at 14:07 +0200, Ingo Molnar wrote:
> > * Gregory Haskins <ghaskins@novell.com> wrote:
> > 
> > > Hi Ingo, Thomas, and the greater linux-rt community,
> > >   
> > > 	I just wanted to let you guys know that our team has a port of 
> > > the 21.5-rt20 patch for the 2.6.22 kernel available. [...]
> > 
> > great! We had the upstream -rt port to .22 in the works too, it was just 
> > held up by the hpet breakage - which Thomas managed to fix earlier 
> > today. I've released the 2.6.22.1-rt1 patch to the usual place:
> > 
> >     http://redhat.com/~mingo/realtime-preempt/
> 
> Thats awesome, Ingo!  Thanks!  Could you publish a broken out version 
> as well?  We found it extremely valuable to be able to bisect this 
> beast while working on the 21-22 port.

we are working on something in this area :) Stay tuned ...

	Ingo

Re: Forward port of latest RT patch (2.6.21.5-rt20) to 2.6.22 available

[Peter Williams]

[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]

Ingo Molnar wrote:
> * Gregory Haskins <ghaskins@novell.com> wrote:
> 
>> On Thu, 2007-07-12 at 14:07 +0200, Ingo Molnar wrote:
>>> * Gregory Haskins <ghaskins@novell.com> wrote:
>>>
>>>> Hi Ingo, Thomas, and the greater linux-rt community,
>>>>   
>>>> 	I just wanted to let you guys know that our team has a port of 
>>>> the 21.5-rt20 patch for the 2.6.22 kernel available. [...]
>>> great! We had the upstream -rt port to .22 in the works too, it was just 
>>> held up by the hpet breakage - which Thomas managed to fix earlier 
>>> today. I've released the 2.6.22.1-rt1 patch to the usual place:
>>>
>>>     http://redhat.com/~mingo/realtime-preempt/
>> Thats awesome, Ingo!  Thanks!  Could you publish a broken out version 
>> as well?  We found it extremely valuable to be able to bisect this 
>> beast while working on the 21-22 port.
> 
> we are working on something in this area :) Stay tuned ...

I've just been reviewing these patches and have spotted an error in the
file mm/slob.c at lines 500-501 whereby a non existent variable "c" is
referenced.  The attached patch is a proposed fix to the problem.

-- 
Peter Williams                                   pwil3058@bigpond.net.au

"Learning, n. The kind of ignorance distinguishing the studious."
 -- Ambrose Bierce

[-- Attachment #2: fix-slob-error.patch --]
[-- Type: text/x-patch, Size: 1346 bytes --]

Fix error in realtime-preempt patch for mm/slob.c

This error was caused by a change to slob_free()'s interface.

Signed-off-by: Peter Williams <pwil3058@bigpond.net.au>

diff -r cb0010b7bffe mm/slob.c
--- a/mm/slob.c	Fri Jul 13 15:24:45 2007 +1000
+++ b/mm/slob.c	Fri Jul 13 16:23:02 2007 +1000
@@ -493,14 +493,14 @@ void *kmem_cache_zalloc(struct kmem_cach
 }
 EXPORT_SYMBOL(kmem_cache_zalloc);
 
-static void __kmem_cache_free(void *b, int size)
+static void __kmem_cache_free(struct kmem_cache *c, void *b)
 {
 	atomic_dec(&c->items);
 
 	if (c->size <= MAX_SLOB_CACHE_SIZE)
 		slob_free(c, b, c->size);
 	else
-		free_pages((unsigned long)b, get_order(size));
+		free_pages((unsigned long)b, get_order(c->size));
 }
 
 static void kmem_rcu_free(struct rcu_head *head)
@@ -508,7 +508,7 @@ static void kmem_rcu_free(struct rcu_hea
 	struct slob_rcu *slob_rcu = (struct slob_rcu *)head;
 	void *b = (void *)slob_rcu - (slob_rcu->size - sizeof(struct slob_rcu));
 
-	__kmem_cache_free(b, slob_rcu->size);
+	__kmem_cache_free(slob_rcu, b);
 }
 
 void kmem_cache_free(struct kmem_cache *c, void *b)
@@ -520,7 +520,7 @@ void kmem_cache_free(struct kmem_cache *
 		slob_rcu->size = c->size;
 		call_rcu(&slob_rcu->head, kmem_rcu_free);
 	} else {
-		__kmem_cache_free(b, c->size);
+		__kmem_cache_free(c, b);
 	}
 }
 EXPORT_SYMBOL(kmem_cache_free);

Re: Forward port of latest RT patch (2.6.21.5-rt20) to 2.6.22 available

[Thomas Gleixner]

On Fri, 2007-07-13 at 16:25 +1000, Peter Williams wrote:
> > we are working on something in this area :) Stay tuned ...
> 
> I've just been reviewing these patches and have spotted an error in the
> file mm/slob.c at lines 500-501 whereby a non existent variable "c" is
> referenced.  The attached patch is a proposed fix to the problem.

Yep, the slob forward port is incomplete. Your patch is definitely more
correct than the stuff which is currently there.

Thanks,

	tglx

Re: Forward port of latest RT patch (2.6.21.5-rt20) to 2.6.22 available

[Gene Heskett]

On Friday 13 July 2007, Peter Williams wrote:
>Ingo Molnar wrote:
>> * Gregory Haskins <ghaskins@novell.com> wrote:
>>> On Thu, 2007-07-12 at 14:07 +0200, Ingo Molnar wrote:
>>>> * Gregory Haskins <ghaskins@novell.com> wrote:
>>>>> Hi Ingo, Thomas, and the greater linux-rt community,
>>>>>
>>>>> 	I just wanted to let you guys know that our team has a port of
>>>>> the 21.5-rt20 patch for the 2.6.22 kernel available. [...]
>>>>
>>>> great! We had the upstream -rt port to .22 in the works too, it was just
>>>> held up by the hpet breakage - which Thomas managed to fix earlier
>>>> today. I've released the 2.6.22.1-rt1 patch to the usual place:
>>>>
>>>>     http://redhat.com/~mingo/realtime-preempt/
>>>
>>> Thats awesome, Ingo!  Thanks!  Could you publish a broken out version
>>> as well?  We found it extremely valuable to be able to bisect this
>>> beast while working on the 21-22 port.
>>
>> we are working on something in this area :) Stay tuned ...
>
>I've just been reviewing these patches and have spotted an error in the
>file mm/slob.c at lines 500-501 whereby a non existent variable "c" is
>referenced.  The attached patch is a proposed fix to the problem.

Could this explain why 2.6.22.1-rt1 seems to use a lot of swap?  I've been as 
high as 570 megs into swap, currently at 286megs after doing a 
swapoff --a;swapon -a about 8 hours ago.

-- 
Cheers, Gene
"There are four boxes to be used in defense of liberty:
 soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
Humorists always sit at the children's table.
		-- Woody Allen

Re: Forward port of latest RT patch (2.6.21.5-rt20) to 2.6.22 available

[Thomas Gleixner]

On Fri, 2007-07-13 at 04:43 -0400, Gene Heskett wrote:
> >> we are working on something in this area :) Stay tuned ...
> >
> >I've just been reviewing these patches and have spotted an error in the
> >file mm/slob.c at lines 500-501 whereby a non existent variable "c" is
> >referenced.  The attached patch is a proposed fix to the problem.
> 
> Could this explain why 2.6.22.1-rt1 seems to use a lot of swap?  I've been as 
> high as 570 megs into swap, currently at 286megs after doing a 
> swapoff --a;swapon -a about 8 hours ago.

No, we disabled SLOB for now. So this is something different.

	tglx

Re: Forward port of latest RT patch (2.6.21.5-rt20) to 2.6.22 available

[Peter Williams]

Gene Heskett wrote:
> On Friday 13 July 2007, Peter Williams wrote:
>> Ingo Molnar wrote:
>>> * Gregory Haskins <ghaskins@novell.com> wrote:
>>>> On Thu, 2007-07-12 at 14:07 +0200, Ingo Molnar wrote:
>>>>> * Gregory Haskins <ghaskins@novell.com> wrote:
>>>>>> Hi Ingo, Thomas, and the greater linux-rt community,
>>>>>>
>>>>>> 	I just wanted to let you guys know that our team has a port of
>>>>>> the 21.5-rt20 patch for the 2.6.22 kernel available. [...]
>>>>> great! We had the upstream -rt port to .22 in the works too, it was just
>>>>> held up by the hpet breakage - which Thomas managed to fix earlier
>>>>> today. I've released the 2.6.22.1-rt1 patch to the usual place:
>>>>>
>>>>>     http://redhat.com/~mingo/realtime-preempt/
>>>> Thats awesome, Ingo!  Thanks!  Could you publish a broken out version
>>>> as well?  We found it extremely valuable to be able to bisect this
>>>> beast while working on the 21-22 port.
>>> we are working on something in this area :) Stay tuned ...
>> I've just been reviewing these patches and have spotted an error in the
>> file mm/slob.c at lines 500-501 whereby a non existent variable "c" is
>> referenced.  The attached patch is a proposed fix to the problem.
> 
> Could this explain why 2.6.22.1-rt1 seems to use a lot of swap?  I've been as 
> high as 570 megs into swap, currently at 286megs after doing a 
> swapoff --a;swapon -a about 8 hours ago.

No.  This problem would have caused the build to fail if slob was
configured.

Peter
-- 
Peter Williams                                   pwil3058@bigpond.net.au

"Learning, n. The kind of ignorance distinguishing the studious."
 -- Ambrose Bierce

Re: Forward port of latest RT patch (2.6.21.5-rt20) to 2.6.22 available

[Gene Heskett]

On Friday 13 July 2007, Peter Williams wrote:
>Gene Heskett wrote:
>> On Friday 13 July 2007, Peter Williams wrote:
>>> Ingo Molnar wrote:
>>>> * Gregory Haskins <ghaskins@novell.com> wrote:
>>>>> On Thu, 2007-07-12 at 14:07 +0200, Ingo Molnar wrote:
>>>>>> * Gregory Haskins <ghaskins@novell.com> wrote:
>>>>>>> Hi Ingo, Thomas, and the greater linux-rt community,
>>>>>>>
>>>>>>> 	I just wanted to let you guys know that our team has a port of
>>>>>>> the 21.5-rt20 patch for the 2.6.22 kernel available. [...]
>>>>>>
>>>>>> great! We had the upstream -rt port to .22 in the works too, it was
>>>>>> just held up by the hpet breakage - which Thomas managed to fix
>>>>>> earlier today. I've released the 2.6.22.1-rt1 patch to the usual
>>>>>> place:
>>>>>>
>>>>>>     http://redhat.com/~mingo/realtime-preempt/
>>>>>
>>>>> Thats awesome, Ingo!  Thanks!  Could you publish a broken out version
>>>>> as well?  We found it extremely valuable to be able to bisect this
>>>>> beast while working on the 21-22 port.
>>>>
>>>> we are working on something in this area :) Stay tuned ...
>>>
>>> I've just been reviewing these patches and have spotted an error in the
>>> file mm/slob.c at lines 500-501 whereby a non existent variable "c" is
>>> referenced.  The attached patch is a proposed fix to the problem.
>>
>> Could this explain why 2.6.22.1-rt1 seems to use a lot of swap?  I've been
>> as high as 570 megs into swap, currently at 286megs after doing a
>> swapoff --a;swapon -a about 8 hours ago.
>
>No.  This problem would have caused the build to fail if slob was
>configured.
>
>Peter

Which, now that I've gone back and looked only has SLAB as the choice in the 
make xconfig.  It did that switch rather silently as I had been using SLUB 
all the way through the 2.6.22-rcN series just to exersize the new option.

In any event, both rt2 and rt3 seem to have that under total control now.  No 
swap is being indicated by htop, and kmail is up to 122 megs.  Uptime with 
rt3 is 8.5 hours now & so far everything is running rather nicely.  Except of 
course for tvtime.  I fwd'd the logs from that to the v4l list, but haven't 
been graced with a reply as yet.

Thanks Peter.

-- 
Cheers, Gene
"There are four boxes to be used in defense of liberty:
 soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
There are three ways to get something done:
	(1) Do it yourself.
	(2) Hire someone to do it for you.
	(3) Forbid your kids to do it.

Minor errors in 2.6.23-rc1-rt2 series

[Peter Williams]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

I've just been reviewing these patches and have spotted a couple of
errors that look like they were caused by fuzz during the patch process.

A patch that corrects the errors is attached.

Cheers
Peter
-- 
Peter Williams                                   pwil3058@bigpond.net.au

"Learning, n. The kind of ignorance distinguishing the studious."
 -- Ambrose Bierce


[-- Attachment #2: fix-fuzz-related-errors --]
[-- Type: text/plain, Size: 1484 bytes --]

diff -r e02fd64426b9 arch/i386/boot/compressed/Makefile
--- a/arch/i386/boot/compressed/Makefile	Thu Jul 26 10:33:58 2007 +1000
+++ b/arch/i386/boot/compressed/Makefile	Thu Jul 26 11:17:35 2007 +1000
@@ -9,10 +9,9 @@ EXTRA_AFLAGS	:= -traditional
 EXTRA_AFLAGS	:= -traditional
 
 LDFLAGS_vmlinux := -T
-CFLAGS := -m32 -D__KERNEL__ -Iinclude -O2  -fno-strict-aliasing
 hostprogs-y	:= relocs
 
-CFLAGS  := -m32 -D__KERNEL__ $(LINUX_INCLUDE) -O2 \
+CFLAGS  := -m32 -D__KERNEL__ $(LINUX_INCLUDE) -Iinclude -O2 \
 	   -fno-strict-aliasing -fPIC \
 	   $(call cc-option,-ffreestanding) \
 	   $(call cc-option,-fno-stack-protector)
diff -r e02fd64426b9 arch/i386/kernel/smp.c
--- a/arch/i386/kernel/smp.c	Thu Jul 26 10:33:58 2007 +1000
+++ b/arch/i386/kernel/smp.c	Thu Jul 26 11:17:35 2007 +1000
@@ -651,7 +651,6 @@ fastcall notrace void smp_reschedule_int
 fastcall notrace void smp_reschedule_interrupt(struct pt_regs *regs)
 {
 	trace_special(regs->eip, 0, 0);
-	trace_special(regs->eip, 0, 0);
 	ack_APIC_irq();
 	set_tsk_need_resched(current);
 }
diff -r e02fd64426b9 include/asm-mips/mipsregs.h
--- a/include/asm-mips/mipsregs.h	Thu Jul 26 10:33:58 2007 +1000
+++ b/include/asm-mips/mipsregs.h	Thu Jul 26 11:17:35 2007 +1000
@@ -710,7 +710,7 @@ do {									\
 	unsigned long long __val;					\
 	unsigned long __flags;						\
 									\
-	local_irq_save(flags);					\
+	local_irq_save(__flags);					\
 	if (sel == 0)							\
 		__asm__ __volatile__(					\
 			".set\tmips64\n\t"				\

Re: Minor errors in 2.6.23-rc1-rt2 series

[Ingo Molnar]

* Peter Williams <pwil3058@bigpond.net.au> wrote:

> I've just been reviewing these patches and have spotted a couple of 
> errors that look like they were caused by fuzz during the patch 
> process.
> 
> A patch that corrects the errors is attached.

thanks, applied!

	Ingo

Possible error in 2.6.23-rc2-rt1 series

[Peter Williams]

I've just been reviewing these patches and have spotted a possible
error in the file arch/ia64/kernel/time.c in that the scope of the
#ifdef on CONFIG_TIME_INTERPOLATION seems to have grown quite a lot
since 2.2.23-rc1-rt7.  It used to chop out one if statement and now it
chops out half the file.

Is it correct?
Peter
-- 
Peter Williams                                   pwil3058@bigpond.net.au

"Learning, n. The kind of ignorance distinguishing the studious."
 -- Ambrose Bierce

Re: Possible error in 2.6.23-rc2-rt1 series

[Ingo Molnar]

* Peter Williams <pwil3058@bigpond.net.au> wrote:

> I've just been reviewing these patches and have spotted a possible 
> error in the file arch/ia64/kernel/time.c in that the scope of the
> #ifdef on CONFIG_TIME_INTERPOLATION seems to have grown quite a lot
> since 2.2.23-rc1-rt7.  It used to chop out one if statement and now it 
> chops out half the file.

i have not got much feedback about the ia64 -rt code. Does it even 
compile? The above thing could be a merge artifact - TIME_INTERPOLATION 
has been removed from upstream recently.

	Ingo