From: "H. Peter Anvin" <hpa@zytor.com>
To: Willy Tarreau <w@1wt.eu>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
Axel Reinhold <axel@freakout.de>,
linux-kernel@vger.kernel.org
Subject: Re: Kernel Bug in 2.4.35 when compiled gcc>=4.2.0 and -march=c3
Date: Mon, 06 Aug 2007 10:39:28 -0700 [thread overview]
Message-ID: <46B75CD0.7080408@zytor.com> (raw)
In-Reply-To: <20070806132658.GE10999@1wt.eu>
Willy Tarreau wrote:
>
> Just to enlighten me on the subject, could you please explain me
> what is wrong in the code ? Granted I found it awful, but even on
> the GCC-4.2 page where -fno-toplevel-reorder is explained, it is
> said that asm statements can be instantiated between functions
> blocks, which is exactly what is used here.
>
A stray semicolon:
__attribute__((regparm(0))) void call_do_IRQ(void); __asm__(...
... is actually a prototype followed by a top-level asm statement
(because of the semicolon), *not* a function with a single-statement
body (which is itself uglier than hell, use braces please...)
-hpa
next prev parent reply other threads:[~2007-08-06 17:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-05 8:56 Kernel Bug in 2.4.35 when compiled gcc>=4.2.0 and -march=c3 Axel Reinhold
2007-08-05 9:49 ` Willy Tarreau
2007-08-05 15:43 ` Willy Tarreau
2007-08-05 19:17 ` Willy Tarreau
2007-08-06 13:05 ` Segher Boessenkool
2007-08-06 13:26 ` Willy Tarreau
2007-08-06 17:39 ` H. Peter Anvin [this message]
2007-08-06 17:45 ` Willy Tarreau
2007-08-06 18:01 ` H. Peter Anvin
2007-08-06 19:13 ` Willy Tarreau
2007-08-06 21:15 ` Segher Boessenkool
2007-08-06 21:16 ` Willy Tarreau
2007-08-07 5:04 ` Axel Reinhold
2007-08-07 8:12 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B75CD0.7080408@zytor.com \
--to=hpa@zytor.com \
--cc=axel@freakout.de \
--cc=linux-kernel@vger.kernel.org \
--cc=segher@kernel.crashing.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox