From: Bernd Schmidt <bernds_cb1@t-online.de>
To: David Howells <dhowells@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Wu, Bryan" <Bryan.Wu@analog.com>
Subject: Re: [PATCH] NOMMU: Separate out VMAs
Date: Tue, 07 Aug 2007 15:37:20 +0200 [thread overview]
Message-ID: <46B87590.60208@t-online.de> (raw)
In-Reply-To: <23350.1186492903@redhat.com>
David Howells wrote:
> + /* we allocated a power-of-2 sized page set, so we need to trim off the
> + * excess */
> + total = 1 << order;
> + atomic_add(total, &mmap_pages_allocated);
> +
> + point = len >> PAGE_SHIFT;
> + while (point < total) {
> + order = ilog2(total - point);
> + _debug("shave %u/%lu", 1 << order, total - point);
> + atomic_sub(1 << order, &mmap_pages_allocated);
> + __free_pages(pages + point, order);
> + point += 1 << order;
> + }
Note that we've had a similar change in our kernel, and we've had to
revert it since the effect on fragmentation is just horrendous. Without
this, we could run a complete gcc testsuite on the board; with it we'd
run out of high-order pages somewhere in the middle.
This probably wants to be dependent on something like MAP_TRIM_EXCESS.
Bernd
--
This footer brought to you by insane German lawmakers.
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 40368
Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif
next prev parent reply other threads:[~2007-08-07 13:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 13:53 [PATCH, RFD]: Unbreak no-mmu mmap Bernd Schmidt
2007-06-09 19:10 ` Matt Mackall
2007-06-11 21:08 ` Robin Getz
2007-06-11 22:09 ` Mike Frysinger
2007-06-11 23:04 ` Bernd Schmidt
2007-06-11 23:22 ` Mike Frysinger
2007-06-19 23:26 ` Robin Getz
2007-06-20 2:38 ` Bryan Wu
2007-06-20 3:00 ` Paul Mundt
2007-06-20 3:18 ` Bryan Wu
2007-06-27 5:50 ` Greg Ungerer
2007-06-22 12:59 ` David Howells
2007-06-22 13:35 ` David Howells
2007-06-22 14:29 ` [PATCH] NOMMU: " David Howells
2007-08-01 12:29 ` [PATCH, RFD]: " David Howells
2007-08-03 14:03 ` [PATCH] NOMMU: Separate out VMAs David Howells
2007-08-07 13:12 ` Bernd Schmidt
2007-08-07 13:17 ` David Howells
2007-08-07 13:21 ` David Howells
2007-08-07 13:37 ` Bernd Schmidt [this message]
2007-08-07 14:03 ` David Howells
2007-08-17 11:49 ` Bernd Schmidt
2007-08-20 15:12 ` David Howells
2007-08-20 16:02 ` Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B87590.60208@t-online.de \
--to=bernds_cb1@t-online.de \
--cc=Bryan.Wu@analog.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox