Re: [PATCH, RFD]: Unbreak no-mmu mmap

Paul Mundt
2007-06-20T03:02:38Z

On Fri, Jun 08, 2007 at 03:53:49PM +0200, Bernd Schmidt wrote:
> diff --git a/mm/nommu.c b/mm/nommu.c
> index 2b16b00..7480a95 100644
> --- a/mm/nommu.c
> +++ b/mm/nommu.c
[snip]
> + /*
> + * Must always set the VM_SPLIT_PAGES flag for single-page allocations,
> + * to avoid trying to get the order of the compound page later on.
> + */
> + if (len == PAGE_SIZE)
> + vma->vm_flags |= VM_SPLIT_PAGES;
> + else if (flags & MAP_SPLIT_PAGES

And now you've just broken every non-blackfin nommu platform, as you've
only defined MAP_SPLIT_PAGES in asm-blackfin/mman.h.

> +#ifdef CONFIG_NP2
> + || len < total_len
> +#endif

And what is this? It only shows up in the blackfin defconfig. This is not
the place to be putting board-specific hacks.

On Tue, Jun 19, 2007 at 07:26:19PM -0400, Robin Getz wrote:
> I'm assuming that since no one had any large objections, that this is OK, and
> we should send to Andrew to live in -mm for awhile?
>
No real objections to the approach, but it would be nice if these sorts
of things were test compiled for at least one platform that isn't yours,
so the obviously broken stuff is fixed before it's posted and someone
else has to find out about it later.