Re: [PATCH, RFD]: Unbreak no-mmu mmap

David Howells
2007-06-22T12:59:26Z

Bernd Schmidt <bernds_cb1@t-online.de> wrote:

> + MAP_PRIVATE | MAP_ANONYMOUS
> + | MAP_GROWSDOWN | MAP_SPLIT_PAGES, 0);

The OR-operator should end the first line.

> diff --git a/include/asm-blackfin/mman.h b/include/asm-blackfin/mman.h
> index 4d504f9..07057b6 100644
> --- a/include/asm-blackfin/mman.h
> +++ b/include/asm-blackfin/mman.h
> @@ -24,6 +24,7 @@
> #define MAP_NONBLOCK 0x10000 /* do not block on IO */
> #define MAP_UNINITIALIZE 0x4000000 /* For anonymous mmap, memory could
> be uninitialized. */
> +#define MAP_SPLIT_PAGES 0x8000000 /* Conserve memory (nommu only). */

Blackfin should really use asm-generic/mman.h if it can.

I'll produce my own version of the patch and pass it back to you once I've got
FRV compiling with it.

David