[PATCH] 2.4.35 compilation failed in LVM

[PATCH] 2.4.35 compilation failed in LVM

[Vincent Legoll]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

Hello,

I tried to get 2.4.35 to compile on a file server I manage, and got that:

gcc -D__KERNEL__ -I/usr/src/linux-2.4/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
-fno-common -fno-builtin-sprintf -fomit-frame-pointer
-Wno-pointer-sign -pipe -mpreferred-stack-boundary=2 -march=i686
-fno-unit-at-a-time -DMODULE -DMODVERSIONS -include
/usr/src/linux-2.4/include/linux/modversions.h  -nostdinc -iwithprefix
include -DKBUILD_BASENAME=lvm  -c -o lvm.o lvm.c
lvm.c:397: error: static declaration of 'vg_count' follows non-static
declaration
lvm-internal.h:48: error: previous declaration of 'vg_count' was here

looking in the 2.4.35 patch, this has been modified, is there already
a fix for that ?

Reverting the attached patch hunk fixed the compilation for me...

-- 
Vincent Legoll

[-- Attachment #2: patch-fix-lvm-compil --]
[-- Type: application/octet-stream, Size: 330 bytes --]

diff --git a/drivers/md/lvm-internal.h b/drivers/md/lvm-internal.h
index aca8632..f95069e 100644
--- a/drivers/md/lvm-internal.h
+++ b/drivers/md/lvm-internal.h
@@ -45,6 +45,7 @@ extern int loadtime;
 extern const char *const lvm_name;
 
 
+extern uint vg_count;
 extern vg_t *vg[];
 extern struct file_operations lvm_chr_fops;
 

Re: [PATCH] 2.4.35 compilation failed in LVM

[Willy Tarreau]

On Tue, Aug 07, 2007 at 03:24:17PM +0200, Vincent Legoll wrote:
> Hello,
> 
> I tried to get 2.4.35 to compile on a file server I manage, and got that:
> 
> gcc -D__KERNEL__ -I/usr/src/linux-2.4/include -Wall
> -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
> -fno-common -fno-builtin-sprintf -fomit-frame-pointer
> -Wno-pointer-sign -pipe -mpreferred-stack-boundary=2 -march=i686
> -fno-unit-at-a-time -DMODULE -DMODVERSIONS -include
> /usr/src/linux-2.4/include/linux/modversions.h  -nostdinc -iwithprefix
> include -DKBUILD_BASENAME=lvm  -c -o lvm.o lvm.c
> lvm.c:397: error: static declaration of 'vg_count' follows non-static
> declaration
> lvm-internal.h:48: error: previous declaration of 'vg_count' was here
> 
> looking in the 2.4.35 patch, this has been modified, is there already
> a fix for that ?

Yes, the fix is already queued in -git for 2.4.35.1 :

   http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.4.35.y.git;a=commitdiff_plain;h=0a1b1818b031b46e3755f12f5cff76df7a0661a8

Best regards,
Willy

Re: [PATCH] 2.4.35 compilation failed in LVM

[Gabriel C]

Vincent Legoll wrote:
> Hello,

Hi,

> 
> I tried to get 2.4.35 to compile on a file server I manage, and got that:
> 
> gcc -D__KERNEL__ -I/usr/src/linux-2.4/include -Wall
> -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing
> -fno-common -fno-builtin-sprintf -fomit-frame-pointer
> -Wno-pointer-sign -pipe -mpreferred-stack-boundary=2 -march=i686
> -fno-unit-at-a-time -DMODULE -DMODVERSIONS -include
> /usr/src/linux-2.4/include/linux/modversions.h  -nostdinc -iwithprefix
> include -DKBUILD_BASENAME=lvm  -c -o lvm.o lvm.c
> lvm.c:397: error: static declaration of 'vg_count' follows non-static
> declaration
> lvm-internal.h:48: error: previous declaration of 'vg_count' was here
> 
> looking in the 2.4.35 patch, this has been modified, is there already
> a fix for that ?

Yes there is :

http://git.kernel.org/?p=linux/kernel/git/wtarreau/linux-2.4.git;a=commitdiff;h=0a1b1818b031b46e3755f12f5cff76df7a0661a8