Re: why are some atomic_t's not volatile, while most are?

Chris Friesen
2007-08-07T22:04:39Z

Chris Snook wrote:

> That's why we define atomic_read like so:
>
> #define atomic_read(v) ((v)->counter)
>
> This avoids the aliasing problem, because the compiler must de-reference
> the pointer every time, which requires a memory fetch.

Can you guarantee that the pointer dereference cannot be optimised away
on any architecture? Without other restrictions, a suficiently
intelligent optimiser could notice that the address of v doesn't change
in the loop and the destination is never written within the loop, so the
read could be hoisted out of the loop.

Even now, powerpc (as an example) defines atomic_t as:

typedef struct { volatile int counter; } atomic_t

That volatile is there precisely to force the compiler to dereference it
every single time.

Chris