From: "Chris Friesen" <cfriesen@nortel.com>
To: Chris Snook <csnook@redhat.com>
Cc: Jerry Jiang <wjiang@resilience.com>,
"Robert P. J. Day" <rpjday@mindspring.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: why are some atomic_t's not volatile, while most are?
Date: Tue, 07 Aug 2007 15:38:22 -0600 [thread overview]
Message-ID: <46B8E64E.7010708@nortel.com> (raw)
In-Reply-To: <46B8E1D3.8050501@redhat.com>
Chris Snook wrote:
> That's why we define atomic_read like so:
>
> #define atomic_read(v) ((v)->counter)
>
> This avoids the aliasing problem, because the compiler must de-reference
> the pointer every time, which requires a memory fetch.
Can you guarantee that the pointer dereference cannot be optimised away
on any architecture? Without other restrictions, a suficiently
intelligent optimiser could notice that the address of v doesn't change
in the loop and the destination is never written within the loop, so the
read could be hoisted out of the loop.
Even now, powerpc (as an example) defines atomic_t as:
typedef struct { volatile int counter; } atomic_t
That volatile is there precisely to force the compiler to dereference it
every single time.
Chris
next prev parent reply other threads:[~2007-08-07 22:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-01 12:49 why are some atomic_t's not volatile, while most are? Robert P. J. Day
2007-08-06 4:35 ` Jerry Jiang
2007-08-06 14:12 ` Chris Snook
2007-08-07 15:51 ` Chris Friesen
2007-08-07 20:32 ` Chris Snook
2007-08-07 21:02 ` Chris Friesen
2007-08-07 21:19 ` Chris Snook
2007-08-07 21:38 ` Chris Friesen [this message]
2007-08-07 22:02 ` Chris Snook
2007-08-07 22:46 ` Chris Friesen
2007-08-07 22:06 ` Jan Engelhardt
2007-08-07 22:49 ` Chris Friesen
2007-08-07 22:32 ` Zan Lynx
2007-08-08 1:31 ` Chris Snook
2007-08-08 4:50 ` Chris Friesen
2007-08-08 6:47 ` Chris Snook
2007-08-08 8:16 ` Jerry Jiang
2007-08-08 8:27 ` Jerry Jiang
2007-08-08 20:54 ` Chris Snook
2007-08-09 12:37 ` Robert P. J. Day
2007-08-09 12:52 ` Chris Snook
2007-08-09 18:02 ` Robert P. J. Day
2007-08-09 18:04 ` Robert P. J. Day
2007-08-08 2:27 ` Jerry Jiang
2007-08-08 5:39 ` Chris Snook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B8E64E.7010708@nortel.com \
--to=cfriesen@nortel.com \
--cc=csnook@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
--cc=wjiang@resilience.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox