Re: [-mm patch] kernel/sysctl_check.c must #include

Eric W. Biederman
2007-08-10T21:32:58Z

Adrian Bunk <bunk@kernel.org> writes:

> On Thu, Aug 09, 2007 at 10:42:54PM -0700, Andrew Morton wrote:
>>...
>> Changes since 2.6.23-rc1-mm2:
>>...
>> +sysctl-core-stop-using-the-unnecessary-ctl_table-typedef.patch
>> +sysctl-factor-out-sysctl_data.patch
>> +sysctl-error-on-bad-sysctl-tables.patch
>> +sysctl-update-sysctl_check_table.patch
>> +sysct-mqueue-remove-the-binary-sysctl-numbers.patch
>> +sysctl-remove-binary-sysctl-support-where-it-clearly-doesnt-work.patch
>> +sysctl-fix-neighbour-table-sysctls.patch
>> +sysctl-ipv6-route-flushing-kill-binary-path.patch
>> +sysctl-remove-broken-sunrpc-debug-binary-sysctls.patch
>> +sysctl-x86_64-remove-unnecessary-binary-paths.patch
>> +sysctl-remove-broken-cdrom-binary-sysctls.patch
>> +sysctl-ipv4-remove-binary-sysctl-paths-where-they-are-broken.patch
>>
> +sysctl-remove-the-binary-interface-for-aio-nr-aio-max-nr-acpi_video_flags.patch
>>
>> sysctl cleanups
>>...
>
> This patch fixes the following compile error:
>
> <-- snip -->
>
> ...
> CC kernel/sysctl_check.o
> /home/bunk/linux/kernel-2.6/linux-2.6.23-rc2-mm2/kernel/sysctl_check.c: In
> function 'sysctl_binary_lookup':
> /home/bunk/linux/kernel-2.6/linux-2.6.23-rc2-mm2/kernel/sysctl_check.c:1303:
> error: implicit declaration of function 'strcmp'
> make[2]: *** [kernel/sysctl_check.o] Error 1
>
> <-- snip -->
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
> --- a/kernel/sysctl_check.c
> +++ b/kernel/sysctl_check.c
> @@ -3,6 +3,7 @@
> #include "../arch/s390/appldata/appldata.h"
> #include "../fs/xfs/linux-2.6/xfs_sysctl.h"
> #include <linux/sunrpc/debug.h>
> +#include <linux/string.h>
> #include <net/ip_vs.h>
>
> struct trans_ctl_table {

Thanks. This problem doesn't happen on x86_64 for some reason so I missed that.

Eric