Re: [-mm patch] unexport cap_inode_killpriv

Adrian Bunk
2007-08-14T23:43:22Z

On Tue, Aug 14, 2007 at 04:35:02PM -0500, Serge E. Hallyn wrote:
> Quoting Adrian Bunk (bunk@kernel.org):
> > On Thu, Aug 09, 2007 at 10:42:54PM -0700, Andrew Morton wrote:
> > >...
> > > Changes since 2.6.23-rc1-mm2:
> > >...
> > > +file-capabilities-clear-fcaps-on-inode-change.patch
> > >
> > > file caps update
> > >...
> >
> > This patch removes the unused EXPORT_SYMBOL(cap_inode_killpriv).
> >
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> Acked-by: Serge Hallyn <serue@us.ibm.com>
>
> > ---
> > 68ca3bcc4918d0b84a97318f60fb74c4600d9f6b
> > diff --git a/security/commoncap.c b/security/commoncap.c
> > index 7816cdc..9ec5890 100644
> > --- a/security/commoncap.c
> > +++ b/security/commoncap.c
> > @@ -543,7 +543,6 @@ EXPORT_SYMBOL(cap_bprm_apply_creds);
> > EXPORT_SYMBOL(cap_bprm_secureexec);
> > EXPORT_SYMBOL(cap_inode_setxattr);
> > EXPORT_SYMBOL(cap_inode_removexattr);
> > -EXPORT_SYMBOL(cap_inode_killpriv);
> > EXPORT_SYMBOL(cap_task_post_setuid);
> > EXPORT_SYMBOL(cap_task_kill);
> > EXPORT_SYMBOL(cap_task_setscheduler);
>
> Ah yes, bc LSMs can't be modules any more. But then, why still export
> cap_task_setscheduler, for instance?

Look at my next patch. :-)

> -serge

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed