From: Ben Greear <greearb@candelatech.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Auke Kok <auke-jan.h.kok@intel.com>,
netdev@vger.kernel.org, davem@davemloft.net,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls
Date: Fri, 10 Aug 2007 14:11:24 -0700 [thread overview]
Message-ID: <46BCD47C.9060408@candelatech.com> (raw)
In-Reply-To: <46BCD263.6050807@garzik.org>
Jeff Garzik wrote:
> This patch copies Auke in adding NETIF_F_LRO. Is that just for
> temporary merging, or does the net core really not touch it at all?
>
> Because, logically, if NETIF_F_LRO exists nowhere else but this patch,
> we should not add it to dev->features. LRO knowledge can be contained
> entirely within the driver, if the net core never tests NETIF_F_LRO.
>
> I haven't reviewed the other NETIF_F_XXX flags, but, that logic can be
> applied to any other NETIF_F_XXX flag: if the net stack isn't using it,
> it's a piece of information specific to that driver.
I believe LRO is going to have to be disabled for routing/bridging,
so the stack will probably need to become aware of it at some point...
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2007-08-10 21:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 20:24 [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls Jeff Garzik
2007-08-10 20:25 ` [PATCH 2/4] ethtool: introduce get_sset_count Jeff Garzik
2007-08-10 20:26 ` [PATCH 3/4] Add ETHTOOL_[GS]PFLAGS sub-ioctls Jeff Garzik
2007-08-10 20:45 ` Driver writer hints (was [PATCH 3/4] Add ETHTOOL_[GS]PFLAGS sub-ioctls) Jeff Garzik
2007-08-10 21:01 ` Rick Jones
2007-08-10 21:08 ` Jeff Garzik
2007-08-10 20:26 ` [PATCH 4/4] ethtool: internal simplification Jeff Garzik
2007-08-10 20:56 ` [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls Jeff Garzik
2007-08-15 23:05 ` David Miller
2007-08-10 21:02 ` Jeff Garzik
2007-08-10 21:11 ` Ben Greear [this message]
2007-08-10 22:10 ` David Miller
2007-08-10 22:40 ` Ben Greear
2007-08-10 22:46 ` David Miller
2007-08-10 23:15 ` Rick Jones
2007-08-14 20:38 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46BCD47C.9060408@candelatech.com \
--to=greearb@candelatech.com \
--cc=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox