From: Rene Herman <rene.herman@gmail.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: Jesper Juhl <jesper.juhl@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: Are we properly prepared to handle 3 Socket setups?
Date: Sun, 12 Aug 2007 05:36:42 +0200 [thread overview]
Message-ID: <46BE804A.8080609@gmail.com> (raw)
In-Reply-To: <ada4pj5l9bi.fsf@cisco.com>
On 08/12/2007 05:29 AM, Roland Dreier wrote:
> > /*
> > * Maximum threshold is 125
> > */
> > threshold = min(125, threshold);
> >
> > as either the comment or the code is wrong and it seems it's the
> > code.
>
> What's the problem? That line sets threshold to the smaller of the
> current value or 125, which is exactly what one would want to do if
> the maximum value is 125. Just do a couple of examples: eg if threshold
> is 100 going into that line, then the value is left alone; if
> threshold is 150 then it gets set to 125; and that seems exactly correct.
Crap, need bed, sorry (the fls/ilog2 things still stand -- quite possibly
both not a problem either).
Rene.
next prev parent reply other threads:[~2007-08-12 3:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-12 1:08 Are we properly prepared to handle 3 Socket setups? Jesper Juhl
2007-08-12 1:27 ` Rene Herman
2007-08-12 1:52 ` Jesper Juhl
2007-08-12 3:17 ` Rene Herman
2007-08-12 3:29 ` Roland Dreier
2007-08-12 3:36 ` Rene Herman [this message]
2007-08-12 8:35 ` Andrew Morton
2007-08-12 20:00 ` Rene Herman
2007-08-13 20:44 ` Christoph Lameter
2007-08-12 7:24 ` Paul Mundt
2007-08-12 8:41 ` Willy Tarreau
2007-08-12 11:46 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46BE804A.8080609@gmail.com \
--to=rene.herman@gmail.com \
--cc=akpm@osdl.org \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox