Re: [PATCH] Fix triplefault on x86-64 bootup

Alexey Dobriyan
2007-08-12T13:12:43Z

On Sun, Aug 12, 2007 at 03:53:57PM +0200, Andi Kleen wrote:
> Alexey Dobriyan <adobriyan@gmail.com> writes:
>
> > On Sun, Aug 12, 2007 at 10:12:52AM +0200, Petr Vandrovec wrote:
> > > --- a/arch/x86_64/lib/memcpy.S
> > > +++ b/arch/x86_64/lib/memcpy.S
> > > @@ -124,6 +124,8 @@ ENDPROC(__memcpy)
> > > .quad memcpy
> > > .quad 1b
> > > .byte X86_FEATURE_REP_GOOD
> > > - .byte .Lfinal - memcpy
> > > + /* Replace only beginning, memcpy is used to apply alternatives, so it
> > > + * is silly to overwrite itself with nops - reboot is only outcome... */
> > > + .byte 2b - 1b
> > > .byte 2b - 1b
> > > .previous
> >
> > Thanks, this fixes E6400 reboots on bootup here.
>
> Please test with only ab144f5ec64c42218a555ec1dbde6b60cf2982d6
> applied (or rather a few patches back in the git history)
> I bet that fixes it already.

Sorry?
/me pulls
/me recompiles
/me sees reboot on boot
/me goes in short unprejudiced bisect session
bisections points to "i386: Make patching more robust, fix paravirt issue"
/me sees Petr's patch
above patch fixes problem