Re: [PATCH] Fix triplefault on x86-64 bootup

Linus Torvalds
2007-08-12T17:56:42Z

On Sun, 12 Aug 2007, Andi Kleen wrote:
>
> Can you please just apply the patch series please?
> This one is fixed in "Make patching more robust, fix paravirt issue"

I *had* applied the patch series, Andi. And that one will do

memcpy(addr, opcode, len);

even though "addr" itself may be all of memcpy().

So the code was buggy, and Petr fixed it, and your patch-series didn't fix
*anything*. In fact, from what I can tell, it's the one that introduced
the problem, because before thatone hit, we'd always do the two-byte
sequence on its own (since the "nop_out()" on the rest of the memcpy would
be called later, and separately, once it didn't matter any more).

So out of 12 patches, 2 caused machines to not even boot. Not good.

Linus