Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls

Kok, Auke
2007-08-14T20:39:44Z

Rick Jones wrote:
> David Miller wrote:
>> From: Ben Greear <greearb@candelatech.com>
>> Date: Fri, 10 Aug 2007 15:40:02 -0700
>>
>>
>>> For GSO on output, is there a generic fallback for any driver that
>>> does not specifically implement GSO?
>>
>> Absolutely, in fact that's mainly what it's there for.
>>
>> I don't think there is any issue. The knob is there via
>> ethtool for people who really want to disable it.
>
> Just to be paranoid (who me?) we are then at a point where what happened
> a couple months ago with forwarding between 10G and IPoIB won't happen
> again - where things failed because a 10G NIC had LRO enabled by default?

we still have the NETIF_F_LRO flag which Jeff will keep around. Perhaps the
IPoIB code can force this to _off_ when setting it up? (or at least warn about it).

Auke