From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933326AbXHNX0E (ORCPT ); Tue, 14 Aug 2007 19:26:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756823AbXHNXZh (ORCPT ); Tue, 14 Aug 2007 19:25:37 -0400 Received: from stargate.chelsio.com ([12.22.49.110]:8583 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761181AbXHNXZg (ORCPT ); Tue, 14 Aug 2007 19:25:36 -0400 Message-ID: <46C239EC.7000505@chelsio.com> Date: Tue, 14 Aug 2007 16:25:32 -0700 From: Divy Le Ray User-Agent: Thunderbird 1.5.0.12 (X11/20070509) MIME-Version: 1.0 To: Jeff Garzik CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Steve Wise Subject: Re: [PATCH 4/13] cxgb3 - use immediate data for offload Tx References: <20070811062949.8076.42523.stgit@speedy5> <46C14106.4080604@garzik.org> In-Reply-To: <46C14106.4080604@garzik.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 14 Aug 2007 23:24:15.0618 (UTC) FILETIME=[3AE4C620:01C7DECA] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jeff Garzik wrote: > > Divy Le Ray wrote: > > From: Divy Le Ray > > > > Send small TX_DATA work requests as immediate data even when > > there are fragments. > > > > Signed-off-by: Divy Le Ray > > --- > > > > drivers/net/cxgb3/sge.c | 17 +++++++++++------ > > 1 files changed, 11 insertions(+), 6 deletions(-) > > needs additional explanation. don't just describe the new post-change > behavior, describe why this change is needed. > > It's an optimization avoiding doing multiple DMAs for small fragmented packets. The driver already implements this optimization for small contiguous packets. Divy