Re: [PATCH] Documentation: fix getdelays.c example -l option and segv

[Balbir Singh <balbir@linux.vnet.ibm.com>]

Michael Neuling wrote:
> Fix a couple of minor issues with the getdelays.c example code. 
> 
> Signed-off-by: Michael Neuling <mikey@neuling.org>
> ---
>  Documentation/accounting/getdelays.c |   21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
> 
> Index: linux-2.6-ozlabs/Documentation/accounting/getdelays.c
> ===================================================================
> --- linux-2.6-ozlabs.orig/Documentation/accounting/getdelays.c
> +++ linux-2.6-ozlabs/Documentation/accounting/getdelays.c
> @@ -196,7 +196,7 @@ void print_delayacct(struct taskstats *t
>  	       "IO    %15s%15s\n"
>  	       "      %15llu%15llu\n"
>  	       "MEM   %15s%15s\n"
> -	       "      %15llu%15llu\n"
> +	       "      %15llu%15llu\n",

This change looks good!

>  	       "count", "real total", "virtual total", "delay total",
>  	       t->cpu_count, t->cpu_run_real_total, t->cpu_run_virtual_total,
>  	       t->cpu_delay_total,
> @@ -335,17 +335,17 @@ int main(int argc, char *argv[])
>  		}
>  	}
> 
> -	if (tid) {
> -		rc = send_cmd(nl_sd, id, mypid, TASKSTATS_CMD_GET,
> -			      cmd_type, &tid, sizeof(__u32));
> -		PRINTF("Sent pid/tgid, retval %d\n", rc);
> -		if (rc < 0) {
> -			fprintf(stderr, "error sending tid/tgid cmd\n");
> -			goto done;
> +	do {
> +		if (tid) {
> +			rc = send_cmd(nl_sd, id, mypid, TASKSTATS_CMD_GET,
> +				      cmd_type, &tid, sizeof(__u32));
> +			PRINTF("Sent pid/tgid, retval %d\n", rc);
> +			if (rc < 0) {
> +				fprintf(stderr, "error sending tid/tgid cmd\n");
> +				goto done;
> +			}
>  		}
> -	}
> 
> -	do {
>  		int i;
> 
>  		rep_len = recv(nl_sd, &msg, sizeof(msg), 0);
> @@ -430,6 +430,7 @@ int main(int argc, char *argv[])
>  			}
>  			na = (struct nlattr *) (GENLMSG_DATA(&msg) + len);
>  		}
> +		sleep(2);

Is this really required? a sleep() in the code. Why do we do multiple send_cmd()'s
in the do loop? I'll test and get back.

>  	} while (loop);
>  done:
>  	if (maskset) {
> 
> 
> 
> 


-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL