public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Michael Neuling <mikey@neuling.org>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org,
	Maxim Uvarov <muvarov@ru.mvista.com>
Subject: Re: [PATCH] Documentation: fix getdelays.c printf bug
Date: Wed, 15 Aug 2007 18:45:51 +0530	[thread overview]
Message-ID: <46C2FC87.7060306@linux.vnet.ibm.com> (raw)
In-Reply-To: <29652.1187179715@neuling.org>

Michael Neuling wrote:
> b663a79c191508f27cd885224b592a878c0ba0f6 incorrectly removed a comma
> from a printf statement.  This causes corruption in the output printing
> or a seg fault.
> 
> Signed-off-by: Michael Neuling <mikey@ozlabs.org>
> ---
>  Documentation/accounting/getdelays.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> akpm: please replace
> documentation-fix-getdelaysc-example-l-option-and-segv.patch with this.
> 
> Index: linux-2.6-ozlabs/Documentation/accounting/getdelays.c
> ===================================================================
> --- linux-2.6-ozlabs.orig/Documentation/accounting/getdelays.c
> +++ linux-2.6-ozlabs/Documentation/accounting/getdelays.c
> @@ -196,7 +196,7 @@ void print_delayacct(struct taskstats *t
>  	       "IO    %15s%15s\n"
>  	       "      %15llu%15llu\n"
>  	       "MEM   %15s%15s\n"
> -	       "      %15llu%15llu\n"
> +	       "      %15llu%15llu\n",
>  	       "count", "real total", "virtual total", "delay total",
>  	       t->cpu_count, t->cpu_run_real_total, t->cpu_run_virtual_total,
>  	       t->cpu_delay_total,

This is exactly what Maxim had sent as well.

Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

      reply	other threads:[~2007-08-15 13:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-10  8:24 [PATCH] Documentation: fix getdelays.c example -l option and segv Michael Neuling
2007-08-10  8:33 ` Andrew Morton
2007-08-10  8:53   ` Michael Neuling
2007-08-15  7:02 ` Balbir Singh
2007-08-15  8:13   ` Michael Neuling
2007-08-15 11:20     ` Balbir Singh
2007-08-15 12:00       ` Michael Neuling
2007-08-15 12:08       ` [PATCH] Documentation: fix getdelays.c printf bug Michael Neuling
2007-08-15 13:15         ` Balbir Singh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46C2FC87.7060306@linux.vnet.ibm.com \
    --to=balbir@linux.vnet.ibm.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikey@neuling.org \
    --cc=muvarov@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox