From: "H. Peter Anvin" <hpa@zytor.com>
To: Guy Streeter <guy.streeter@gmail.com>
Cc: James Pearson <james-p@moving-picture.com>, linux-kernel@vger.kernel.org
Subject: Re: 4096 byte limit to /proc/PID/environ ?
Date: Wed, 15 Aug 2007 10:25:20 -0700 [thread overview]
Message-ID: <46C33700.1060605@zytor.com> (raw)
In-Reply-To: <52dd17640708150954q798d137cn1b07739785917c5b@mail.gmail.com>
Guy Streeter wrote:
> On 6/1/06, James Pearson <james-p@moving-picture.com> wrote:
>> H. Peter Anvin wrote:
>>> I think this is the wrong approach.
>>>
>>> Many of these should probably be converted to seq_file, but in the
>>> particular case of environ, the right approach is to observe the fact
>>> that reading environ is just like reading /proc/PID/mem, except:
>>>
>>> a. the access restrictions are less strict, and
>>> b. there is a range restriction, which needs to be enforced, and
>>> c. there is an offset.
>>>
>>> Pretty much, take the guts from /proc/PID/mem and generalize it
>>> slightly, and you have the code that can run either /proc/PID/mem or
>>> /proc/PID/environ.
>> The following patch is based on the /proc/PID/mem code appears to work fine.
>>
>
> This thread has gone stale. The PAGE_SIZE limit still exists. Is this
> solution acceptable?
>
Can we avoid the code duplication?
-hpa
next prev parent reply other threads:[~2007-08-15 17:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-24 19:45 4096 byte limit to /proc/PID/environ ? James Pearson
2006-05-24 20:29 ` H. Peter Anvin
[not found] ` <200605242029.k4OKTn9C031700@terminus.zytor.com>
2006-06-01 14:11 ` James Pearson
2007-08-15 16:54 ` Guy Streeter
2007-08-15 17:25 ` H. Peter Anvin [this message]
2007-08-21 14:40 ` Guy Streeter
2007-08-30 13:53 ` James Pearson
2007-09-03 8:17 ` Anton Arapov
2007-09-05 7:49 ` Anton Arapov
2007-09-05 7:58 ` H. Peter Anvin
2007-09-05 17:00 ` James Pearson
2007-09-05 17:18 ` Randy Dunlap
2007-09-06 9:23 ` James Pearson
2007-09-05 17:22 ` Alexey Dobriyan
2007-09-06 9:31 ` James Pearson
2007-09-06 12:31 ` Jan Engelhardt
2007-09-06 12:34 ` H. Peter Anvin
2007-09-06 12:34 ` Anton Arapov
-- strict thread matches above, loose matches on Subject: below --
2007-09-06 16:38 James Pearson
2007-09-18 14:09 ` Anton Arapov
2007-09-18 17:09 ` H. Peter Anvin
2006-05-24 15:54 James Pearson
2006-05-24 16:46 ` linux-os (Dick Johnson)
2006-05-24 16:59 ` James Pearson
2006-05-24 17:56 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C33700.1060605@zytor.com \
--to=hpa@zytor.com \
--cc=guy.streeter@gmail.com \
--cc=james-p@moving-picture.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox