Re: 4096 byte limit to /proc/PID/environ ?

Anton Arapov
2007-09-03T08:17:29Z

[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

James Pearson <james-p@moving-picture.com> writes:
> H. Peter Anvin wrote:
>> Guy Streeter wrote:
>>>On 6/1/06, James Pearson <james-p@moving-picture.com> wrote:
>>>>H. Peter Anvin wrote:
[...skipped...]
>>>>The following patch is based on the /proc/PID/mem code appears to work fine.
>>>This thread has gone stale. The PAGE_SIZE limit still exists. Is this
>>>solution acceptable?
>> Can we avoid the code duplication?
> There isn't that much that is duplicated - and there are also bits of
> the /proc/PID/mem code that are not needed in this case, so I'm not
> really sure if it is worth doing.
>
> I did submit a patch a few months ago - see:
> <http://marc.info/?l=linux-kernel&m=117862109623007&w=2>
Yep, I'm sure we should not reuse something from mem part, there are some insignificant code duplicating. If we will try to avoid this, it will complicate code and does not bring any advantage.

--
Anton Arapov, <aarapov@redhat.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]