Re: 4096 byte limit to /proc/PID/environ ?

Jan Engelhardt
2007-09-06T12:31:37Z

On Sep 5 2007 18:00, James Pearson wrote:
>
> OK, here is the patch (without the long line) against 2.6.23-rc5 - what else
> needs to be done to get it committed?

Someone has to point out CodingStyle, so I'll ruin everyone's day now :)

> +static ssize_t environ_read(struct file * file, char __user * buf,
^ ^
be gone these spaces.

> + while (count > 0) {
> + int this_len, retval;
> +
> + this_len = mm->env_end - (mm->env_start + src);
> +
> + if (this_len <= 0) {
> + break;
> + }

Be gone, braces.