Re: 4096 byte limit to /proc/PID/environ ?

H. Peter Anvin
2007-08-15T17:25:38Z

Guy Streeter wrote:
> On 6/1/06, James Pearson <james-p@moving-picture.com> wrote:
>> H. Peter Anvin wrote:
>>> I think this is the wrong approach.
>>>
>>> Many of these should probably be converted to seq_file, but in the
>>> particular case of environ, the right approach is to observe the fact
>>> that reading environ is just like reading /proc/PID/mem, except:
>>>
>>> a. the access restrictions are less strict, and
>>> b. there is a range restriction, which needs to be enforced, and
>>> c. there is an offset.
>>>
>>> Pretty much, take the guts from /proc/PID/mem and generalize it
>>> slightly, and you have the code that can run either /proc/PID/mem or
>>> /proc/PID/environ.
>> The following patch is based on the /proc/PID/mem code appears to work fine.
>>
>
> This thread has gone stale. The PAGE_SIZE limit still exists. Is this
> solution acceptable?
>

Can we avoid the code duplication?

-hpa