From: Gerd Hoffmann <kraxel@redhat.com>
To: Robin Getz <rgetz@blackfin.uclinux.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Early printk behaviour
Date: Thu, 16 Aug 2007 09:45:35 +0200 [thread overview]
Message-ID: <46C4009F.9090206@redhat.com> (raw)
In-Reply-To: <200708152234.06734.rgetz@blackfin.uclinux.org>
Robin Getz wrote:
> I was putting together an early printk implementation for the Blackfin, and
> was wondering what the expected behaviour was in this situation.
>
> When I set up my bootargs earlyprintk=serial,ttyBF0,57600 and have no console
> defined (no graphical console, no serial console).
>
> based on the patch:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=69331af79cf29e26d1231152a172a1a10c2df511
>
> which no longer calls disable_early_printk, the earlyprintk console never gets
> turned off (because nothing else ever calls register_console). I get
> everything out the early console, until the init section is released (where
> the console structure is sitting), and it starts printing out garbage.
>
> Is this expected behaviour?
Hmm, sort of, although I didn't think about the case of no real console
replacing the early console. The intention of the patch is to have a
smooth handover from the boot console to the real console. And, yes, if
no real console is ever registered the boot console keeps running ...
So you can either let it running and *not* mark it __init, so it can
keep on going without breaking. Or you can explicitly unregister your
boot console at some point, maybe using a late_initcall.
cheers,
Gerd
next prev parent reply other threads:[~2007-08-16 7:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 2:34 Early printk behaviour Robin Getz
2007-08-16 7:45 ` Gerd Hoffmann [this message]
2007-08-16 16:47 ` Mike Frysinger
2007-08-17 7:49 ` Gerd Hoffmann
2007-08-17 21:00 ` Robin Getz
2007-08-17 21:09 ` Mike Frysinger
2007-08-17 21:29 ` Robin Getz
2007-08-20 8:01 ` Gerd Hoffmann
2007-08-16 18:56 ` Robin Getz
2007-08-17 17:36 ` [draft] Blackfin Early Printk implmentation Robin Getz
2007-08-17 17:57 ` Mike Frysinger
2007-08-17 18:25 ` Robin Getz
2007-08-17 18:43 ` Mike Frysinger
2007-08-17 17:59 ` Sam Ravnborg
2007-08-17 20:07 ` Robin Getz
2007-08-18 6:23 ` Sam Ravnborg
2007-08-18 15:37 ` Robin Getz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C4009F.9090206@redhat.com \
--to=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rgetz@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox