From: "H. Peter Anvin" <hpa@zytor.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andi Kleen <ak@suse.de>, Yinghai Lu <yhlu.kernel@gmail.com>,
"Huang, Ying" <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Chandramouli Narayanan <mouli@linux.intel.com>,
linux-kernel@vger.kernel.org, Aaron Durbin <adurbin@google.com>
Subject: Re: [PATCH 0/3] x86_64 EFI runtime service support
Date: Wed, 22 Aug 2007 09:44:33 -0700 [thread overview]
Message-ID: <46CC67F1.9020005@zytor.com> (raw)
In-Reply-To: <m1absjpr6w.fsf@ebiederm.dsl.xmission.com>
Eric W. Biederman wrote:
> I need to review HPA changes a little more from his rewrite in C.
> I think he messed up with the guarantee of initialization in that
> rewrite, but I'm not quite certain.
I beg to differ, sir!
In my rewritten code, the "zeropage" is 4K of zero-initialized .bss,
into which the setup header is copied.
So any undefined field will be initialized to zero, not to whatever
assembly code happened to be there.
You know that with the old code, we got boot failures after changing the
error message in the dummy boot sector?
-hpa
next prev parent reply other threads:[~2007-08-22 16:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-13 7:30 [PATCH 0/3] x86_64 EFI runtime service support Huang, Ying
2007-08-15 22:42 ` Andrew Morton
2007-08-16 7:51 ` Huang, Ying
2007-08-16 14:11 ` Andi Kleen
2007-08-17 1:25 ` Huang, Ying
2007-08-17 16:11 ` H. Peter Anvin
2007-08-20 3:20 ` Huang, Ying
2007-08-20 17:12 ` H. Peter Anvin
2007-08-21 1:44 ` Huang, Ying
2007-08-21 3:54 ` H. Peter Anvin
2007-08-21 4:53 ` Huang, Ying
2007-08-21 11:33 ` Andi Kleen
2007-08-21 10:41 ` H. Peter Anvin
2007-08-21 11:45 ` Andi Kleen
2007-08-21 23:58 ` Yinghai Lu
2007-08-22 1:22 ` Andi Kleen
2007-08-22 6:43 ` Yinghai Lu
2007-08-22 11:11 ` Andi Kleen
2007-08-22 14:23 ` huang ying
2007-08-22 16:28 ` H. Peter Anvin
2007-08-23 2:21 ` Huang, Ying
2007-08-23 2:46 ` H. Peter Anvin
2007-08-22 14:41 ` Eric W. Biederman
2007-08-22 16:44 ` H. Peter Anvin [this message]
2007-08-22 7:20 ` Yinghai Lu
2007-08-15 23:16 ` Andrew Morton
2007-08-15 23:22 ` H. Peter Anvin
2007-08-16 8:00 ` Huang, Ying
2007-08-16 16:09 ` H. Peter Anvin
2007-08-19 22:27 ` Eric W. Biederman
2007-08-19 22:25 ` Eric W. Biederman
2007-08-19 23:46 ` Yinghai Lu
2007-08-20 17:05 ` H. Peter Anvin
2007-08-20 17:20 ` San Mehat
2007-08-20 20:13 ` Matthew Garrett
2007-08-20 5:14 ` Huang, Ying
2007-08-16 7:52 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46CC67F1.9020005@zytor.com \
--to=hpa@zytor.com \
--cc=adurbin@google.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mouli@linux.intel.com \
--cc=yhlu.kernel@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox