* [PATCH] Move PREEMPT_NOTIFIERS into an always-included Kconfig
@ 2007-08-23 9:34 Avi Kivity
2007-08-23 13:33 ` Roman Zippel
0 siblings, 1 reply; 3+ messages in thread
From: Avi Kivity @ 2007-08-23 9:34 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Roman Zippel, Geert Uytterhoeven, Avi Kivity
Kconfig.preempt is not included on some archs (for example, m68k). On those
archs, the Kconfig machinery complains that KVM selects an undefined symbol
PREEMPT_NOTIFIERS (which lives in Kconfig.preempt). Pointing out that this
is a Kconfig bug does not seem to silence the error, so move the offending
symbol into a Kconfig file which is included by everyone.
Cc: Roman Zippel <zippel@linux-m68k.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Avi Kivity <avi@qumranet.com>
diff --git a/init/Kconfig b/init/Kconfig
index 96b5459..aae3928 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -667,3 +667,6 @@ config STOP_MACHINE
Need stop_machine() primitive.
source "block/Kconfig"
+
+config PREEMPT_NOTIFIERS
+ bool
diff --git a/kernel/Kconfig.preempt b/kernel/Kconfig.preempt
index 6b06663..c64ce9c 100644
--- a/kernel/Kconfig.preempt
+++ b/kernel/Kconfig.preempt
@@ -63,6 +63,3 @@ config PREEMPT_BKL
Say Y here if you are building a kernel for a desktop system.
Say N if you are unsure.
-config PREEMPT_NOTIFIERS
- bool
-
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Move PREEMPT_NOTIFIERS into an always-included Kconfig
2007-08-23 9:34 [PATCH] Move PREEMPT_NOTIFIERS into an always-included Kconfig Avi Kivity
@ 2007-08-23 13:33 ` Roman Zippel
2007-08-23 13:38 ` Avi Kivity
0 siblings, 1 reply; 3+ messages in thread
From: Roman Zippel @ 2007-08-23 13:33 UTC (permalink / raw)
To: Avi Kivity; +Cc: Andrew Morton, linux-kernel, Geert Uytterhoeven
Hi,
On Thu, 23 Aug 2007, Avi Kivity wrote:
> Pointing out that this
> is a Kconfig bug does not seem to silence the error,
*sigh*
This is not a Kconfig bug!
bye, Roman
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Move PREEMPT_NOTIFIERS into an always-included Kconfig
2007-08-23 13:33 ` Roman Zippel
@ 2007-08-23 13:38 ` Avi Kivity
0 siblings, 0 replies; 3+ messages in thread
From: Avi Kivity @ 2007-08-23 13:38 UTC (permalink / raw)
To: Roman Zippel; +Cc: Andrew Morton, linux-kernel, Geert Uytterhoeven
Roman Zippel wrote:
> Hi,
>
> On Thu, 23 Aug 2007, Avi Kivity wrote:
>
>
>> Pointing out that this
>> is a Kconfig bug does not seem to silence the error,
>>
>
> *sigh*
> This is not a Kconfig bug!
>
I take it back, then.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-23 13:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-23 9:34 [PATCH] Move PREEMPT_NOTIFIERS into an always-included Kconfig Avi Kivity
2007-08-23 13:33 ` Roman Zippel
2007-08-23 13:38 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox